Repository navigation
[AMD][bugfix] Fix dsv4 server launch - #39875
Merged
Merged
Conversation
-Declare v41::store_row on ROCm to fix the JIT build -Pass req_pool_indices_repeated when building verify metadata
RolaoDenthu
requested review from
BBuf,
DarkSharpness,
Fridge003,
HaiShaw,
HydraQYH,
Qiaolin-Yu,
celve,
hebiao064,
ispobock,
merrymercy and
yuan-luo
as code owners
September 17, 2026 01:01
Collaborator
HaiShaw
approved these changes
Sep 17, 2026
Collaborator
|
HIP/ROCm specific |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#39652 (
13d593b6cf) breaks the JIT build. It added the V4.1 row quantizers behind#ifndef USE_ROCMinkv_layout.cuh,branch that a V4 instantiation discards, but a discarded branch is still parsed and the
name does not depend on the template parameters, so lookup runs on it whatever the layout
being compiled, and every ROCm build of those headers fails:
#37810 (
a813224e78) breaks target-verify metadata. It added thereq_pool_indices_repeatedparameter to_attach_unified_kv_prefill_metaand updated one of its two call sites. The other one, inmake_forward_metadata_from_raw_verify, is left one positional argument short, sonum_tokensnever binds and the call raisesTypeError.Modifications
kv_layout.cuh: declare av41::store_rowstub underUSE_ROCMso the name resolves there. Itsstatic_assertdepends onkLayout, so it fires only when a kernel really instantiates a V4.1 layout — which the Python side already refuses on ROCm (compress.py,attn.pyandelementwise.pyall assert "the V4.1 KV layouts are CUDA (sm100) only"). Nothing inside the#ifndef USE_ROCMbranch changed, so CUDA codegen is untouched.deepseek_v4_backend_hip_radix.py: passreq_pool_indices_repeatedfrommake_forward_metadata_from_raw_verifyas well.Accuracy Tests
gsm8k 1319 acc: 0.947
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #35168940597
Latest PR Test (Extra): ❌ Run #35168940370
Latest PR Test (AMD ROCm 10): ❌ Run #35168940507