Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/sgl-router/monitoring/grafana-dashboard.json
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@
{
"type": "timeseries",
"title": "Responses by HTTP status",
"description": "Client-visible HTTP status codes (2xx/4xx/5xx, 504=stale-cancel).",
"description": "Client-visible HTTP status codes. A 504 is any router-side give-up \u2014 the stale-request deadline or an upstream timeout \u2014 or a worker 504 forwarded unchanged; worker_requests_total{outcome} tells them apart.",
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
Expand Down
7 changes: 6 additions & 1 deletion experimental/sgl-router/src/proxy/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,15 @@ impl Proxy {
let bytes = match resp.bytes().await {
Ok(b) => b,
Err(e) => {
// Walk the full source chain (`{:#}`) like the connect-error
// handler in `classify_reqwest_error_for` — a mid-body drop's
// real cause (incomplete message, connection reset) lives in the
// wrapped source, not the outer reqwest error.
let cause = anyhow::Error::new(e);
tracing::warn!(
upstream = %url,
status = %status,
error = ?e,
error = %format_args!("{cause:#}"),
"upstream dropped connection mid-body",
);
breaker.record_failure();
Expand Down
Loading
Loading