Repository navigation
Conversation
Collaborator
Author
|
move to #37474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--mamba-radix-cache-strategy extra_buffer(orextra_buffer_lazy) on a model with no mamba state arms the mamba ping-pong track buffers, which are never allocated, so the scheduler crashes at decode:The default strategy is
auto, and theauto -> extra_bufferresolution is already gated on the model architecture, soautonever reaches this on a non-mamba arch. Only an explicitextra_buffer/extra_buffer_lazydoes, which is a misconfiguration.handle_mamba_radix_cachealready returns early for a non-mamba arch, so nothing validates the explicit strategy before it reaches the runtime. This rejects it at resolution with a clear message instead:autoandno_bufferstay inert on a non-mamba arch. This is an alternative to #37474, which gates the extra-buffer predicates on a new architecture-derived leaf rather than failing fast.Test
test/registered/unit/server_args/test_mamba_extra_buffer_arch_guard.py, CPU. The raises case fails on main and passes with this change. The auto/no_buffer case passes on both.Repro on Qwen2.5-0.5B-Instruct (non-mamba), single GPU. Before: launching with
--mamba-radix-cache-strategy extra_bufferstarts, then the scheduler dies with the NoneType error above. After: the launch exits at startup with the ValueError above, before the server comes up.CI States
Latest PR Test (Base): 🚫 Run #35083432358
Latest PR Test (Extra): ❌ Run #35083431958
Latest PR Test (AMD ROCm 10): ❌ Run #35083432336