[Diffusion] Recover IPC JIT initialization after interrupted builds - #39034
Merged
mickqian merged 1 commit intoSep 11, 2026
Merged
Conversation
mickqian
requested review from
AgainstEntropy,
BBuf,
DarkSharpness,
HaiShaw,
HydraQYH,
celve,
ping1jing2,
yichiche and
yuan-luo
as code owners
September 11, 2026 06:25
Collaborator
Author
|
/tag-and-rerun-ci |
This was referenced Sep 11, 2026
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Sep 15, 2026
…lds (sgl-project#39034) Co-authored-by: Mick Qian <mickqian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The two-rank Ulysses IPC synchronization loader uses
torch.utils.cpp_extension.load_inlinewith persistent per-device build directories. If a build is interrupted, its FileBatonlockcan remain after the owner exits. Later workers wait indefinitely inFileBaton.wait()during the first IPC operation, preventing server warmup from completing.This addresses a reproducible interrupted-build failure mode investigated after a diffusion CI warmup timeout. The historical job did not capture a blocked-worker stack, so this PR does not claim conclusive attribution of that particular timeout.
Modifications
flocklocking and atomic cache publication.Accuracy Tests
The added regression checks exact IPC input/output round trips on a nondefault stream and three CUDA Graph replays. NVIDIA CI results are pending on this PR.
Speed Tests and Profiling
This is an initialization reliability fix, not a throughput optimization. No speedup claim.
Checklist
CI States
Latest PR Test (Base): ⏳ Run #34569843379
Latest PR Test (Extra): ❌ Run #34569843057
Latest PR Test (AMD ROCm 10): ❌ Run #34569843327