Repository navigation
[Test] Fix Q8KV8 sparse-prefill pool fixture after page-size rename - #39019
Merged
Merged
Conversation
kpham-sgl
approved these changes
Sep 11, 2026
4 of 5 tasks
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #38954 renamed the pool field to
swa_page_size, the Q8KV8 sparse-prefill tests still exposeswa_window_sizeon their mock pool. The backend raisesAttributeErrorbefore the workspace comparison can run.Modifications
Update the mock field and its
get_extra_key_page_sizegetter to useswa_page_size. Two-line, test-only fix; no production changes.Accuracy Tests
Ran the existing test file on CUDA before and after the fix:
40a84d6dfc: 3 failed, 9 passed, 2 skipped.pre-commit run --files test/registered/kernels/ops/attention/test_q8kv8_sparse_prefill_backend.py: passed with the local base set toupstream/main.Speed Tests and Profiling
Not applicable: no runtime or kernel changes.
Checklist
CI States
Latest PR Test (Base): ❌ Run #34565335083
Latest PR Test (Extra): ❌ Run #34565334771
Latest PR Test (AMD ROCm 10): ❌ Run #34565335140