[AMD][CI] Retire the ROCm 7.0 kernel wheel - #38767
Merged
Merged
Conversation
cursor
Bot
force-pushed
the
cursor/drop-rocm700-image-build-and-ci-d06d
branch
from
September 10, 2026 07:04
569e64d to
933d989
Compare
michaelzhang-ai
marked this pull request as ready for review
September 10, 2026 07:07
michaelzhang-ai
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
September 10, 2026 07:07
cursor
Bot
force-pushed
the
cursor/drop-rocm700-image-build-and-ci-d06d
branch
from
September 10, 2026 07:51
2692672 to
e4aae9b
Compare
The rocm700 leg is the only ROCm kernel-wheel flavor with no CI behind it: it builds in a frozen v0.5.8.post1-rocm700-mi35x image against pinned rocm-rel-7.0.2 wheels. Drop the workflow target, the build-script branch, the amd-sglang extra it fed, and the ROCm 7.0.0 install docs. Co-authored-by: quitenode <quitenode@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/drop-rocm700-image-build-and-ci-d06d
branch
from
September 10, 2026 14:31
e4aae9b to
81733a6
Compare
bingxche
approved these changes
Sep 11, 2026
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Sep 15, 2026
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: quitenode <quitenode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#38763 added a ROCm 10 kernel wheel, making the ROCm wheel matrix
["700", "720", "1000"].rocm700is now the only leg with no CI behind it, and it is the last ROCm 7.0 artifact SGLang still publishes on every kernel version bump.Scope note: this PR was originally a broader ROCm 7.0 retirement (workflows, nightly image build, release image matrix). #38632 supersedes all of that with a better end state — it consolidates the AMD workflows back onto a single
pr-test-amd.yml/nightly-test-amd.ymlpair and retires ROCm 7.0 CI as a consequence. Rather than conflict with it on the same four workflow files, this PR is now reduced to the one ROCm 7.0 surface #38632 does not touch: the kernel wheel.Modifications
Retire the ROCm 7.0 kernel wheel end-to-end:
.github/workflows/release-whl-kernel.yml: drop therocm700dispatch option, therocm700clause in thebuild-rocm-matrixguard, the"700"matrix entry, and therelease-rocm700job (which published the artifact and ranupdate_kernel_whl_index.py --rocm 700). The ROCm wheel matrix becomes["720", "1000"].3rdparty/amd/wheel/sgl-kernel/build_rocm.sh: drop the700build image (lmsysorg/sglang:v0.5.8.post1-rocm700-mi35x) and its pinnedrocm-rel-7.0.2torch/triton/torchaudio/torchvision install branch.720and1000are unchanged, and an explicit700argument now fails with a clear message.3rdparty/amd/wheel/sglang/pyproject.toml: remove therocm700optional-dependency extra (which pinnedsglang_kernel-0.4.0+rocm700) and the stale install comment.rocm720is unchanged.3rdparty/amd/wheel/README.md: remove the ROCm 7.0.0pip install "amd-sglang[all-hip,rocm700]"recipe and the ROCm 7.0.0 Triton upgrade note, and correct the extras description. Also fixes the section heading typoRevolving triton→Resolving triton.#38763's ROCm 10 wheel path is untouched.What this does not touch
The remaining ROCm 7.0 references are deliberately out of scope:
release-docker-amd.ymlmatrix leg — all handled by [AMD][CI] Consolidate AMD workflows and retire ROCm 7.0 CI #38632.scripts/ci/amd/amd_ci_start_container*.shstill default toROCM_VERSION=rocm700. This cannot change independently: all 58 container-launch sites in the currentpr-test-amd.yml/nightly-test-amd.ymlomit--rocm-versionand rely on that default, so flipping it torocm10before those workflows are deleted would silently repoint the ROCm 7.0 runs at ROCm 10 images. It belongs with [AMD][CI] Consolidate AMD workflows and retire ROCm 7.0 CI #38632 or a follow-up.docker/rocm.Dockerfileretains the unsuffixedgfx942/gfx950ROCm 7.0 stages for local builds.SGLANG_USE_ROCM700Ais misleadingly named but gates a workaround current ROCm 7.2 images still set.rocm700image tags for reproducibility.Accuracy Tests
Not applicable — release-artifact configuration only; no runtime or kernel code changed.
Speed Tests and Profiling
Not applicable. Removes one wheel build leg on the shared
amd-docker-scalenode plus its release job from every kernel version bump.Verification
rocm700, ROCm 7.0 dependency URL,"700"build input, or--rocm 700remains inrelease-whl-kernel.ymlor3rdparty/amd/wheel/.release-whl-kernel.ymlparses as YAML; the surviving legs arerocm720/rocm1000in the dispatch menu, the["720", "1000"]matrix, and therelease-rocm720/release-rocm1000jobs.build_rocm.shpassesbash -n;720and1000still resolve their images, and700exits 1 withOnly '720' and '1000' are supported.pyproject.tomlparses withtomllib; the only remainingrocm*extra isrocm720.python3 scripts/lint/check_workflow_job_names.pypasses.Checklist
CI States
Latest PR Test (Base): ✅ Run #34489631801
Latest PR Test (Extra): ❌ Run #34489631335
Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.