Skip to content

docker(xpu): drop redundant setvars.sh from torch_memory_saver RUN #38665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mingfeima merged 2 commits into from
Sep 10, 2026
Merged

docker(xpu): drop redundant setvars.sh from torch_memory_saver RUN #38665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3585e73
docker(xpu): drop redundant setvars.sh from torch_memory_saver RUN
arathi-hlab Sep 9, 2026
8e1d826
chore: retrigger CI
arathi-hlab Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions docker/xpu.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,9 @@ RUN echo "Cloning ${SG_LANG_BRANCH} from ${SG_LANG_REPO}" && \
# major to it -- under build isolation torch is absent and the match is skipped.
# Pinned (v0.0.10b2) so image builds are reproducible; bump via --build-arg.
ARG TORCH_MEMORY_SAVER_REF=a5c99f11b18ebb8e9fda71a68812e476ae49e417
# Keep setvars.sh's stderr and don't chain with `&&`: an optional component's
# vars.sh can exit non-zero while SYCL is still exported. `set -e` fails on pip.
RUN set -e; \
. /opt/intel/oneapi/setvars.sh --force || \
echo "setvars.sh exited $? -- continuing; pip will fail loudly if SYCL is missing"; \
TMS_PLATFORM=xpu pip install --no-cache-dir --no-build-isolation \
git+https://github.com/fzyzcjy/torch_memory_saver.git@${TORCH_MEMORY_SAVER_REF}

CMD ["bash", "-c", "source /opt/intel/oneapi/setvars.sh --force && exec bash"]
# Base image already applies setvars.sh in its own layers (SETVARS_COMPLETED=1,
# icpx on PATH, LIBRARY_PATH/CPATH populated), so re-sourcing here is redundant.
RUN TMS_PLATFORM=xpu pip install --no-cache-dir --no-build-isolation \
git+https://github.com/fzyzcjy/torch_memory_saver.git@${TORCH_MEMORY_SAVER_REF}

CMD ["bash"]
Loading