Conversation
Signed-off-by: bingxche <bingxche@amd.com>
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
PR #26383 (
deaba74745d7) introduced this regression. It changed HIP-Radix target verification to build full metadata early from CPU sequence lengths. Before that change, CUDA Graph target verification built its compression plan from GPU data. After it, fixed-size MTP graph replay accidentally started using the CPU planner.The CPU planner fills a temporary pinned-memory buffer and starts an asynchronous copy to the GPU. CUDA Graph captures that copy for later replay, but the temporary CPU buffer is not kept as graph state. A replay can therefore use stale plan offsets. The C128 write kernel then writes outside its allocation, causing the multi-rank GPU memory fault and scheduler exit
-6. The later connection failures andKeyError: answerhappen only because the server has already crashed.PR #30964 later added the GPU planner for ragged target verification, where CPU sequence lengths are unavailable. Its check covered only ragged layouts, so fixed-size MTP graph replay remained on the unsafe path. In short: #26383 introduced the bad graph behavior; #30964 left that fixed-size case uncovered.
Failing job: https://github.com/sgl-project/sglang/actions/runs/33538157363/job/99957472899
Fix
Use the existing GPU planner in the two cases that require it: CUDA Graph replay, and ragged verification without CPU sequence lengths. Fixed-size eager verification keeps the existing CPU planner because it does not replay the temporary host buffer and avoids an extra GPU planning launch. Normal prefill, decode, and draft extension are unchanged.
Validation
ROCm 7.2.4, 8x MI355X, DeepSeek-V4-Pro FP4 MTP:
The full MTP run used SGLang
9a05b470plus this planner change. The planner hunk and the MTP path it exercises are unchanged on the current PR base.Checklist
CI States
Latest PR Test (Base): ❌ Run #34335075601
Latest PR Test (Extra): ❌ Run #34335075206
Latest PR Test (AMD ROCm 10): ❌ Run #34335075672