[AMD] Fix DeepSeek block-FP8 loading on gfx94x - #38446
Merged
Merged
Conversation
Signed-off-by: Bingxu Chen <bingxche@amd.com>
bingxche
force-pushed
the
codex/fix-amd-ue8m0-attr
branch
from
September 8, 2026 07:39
71ec480 to
4788c2c
Compare
bingxche
marked this pull request as ready for review
September 8, 2026 14:24
bingxche
requested review from
Fridge003,
ch-wan,
fzyzcjy and
ispobock
as code owners
September 8, 2026 14:24
This was referenced Sep 8, 2026
HaiShaw
approved these changes
Sep 11, 2026
This was referenced Sep 12, 2026
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Sep 15, 2026
Signed-off-by: Bingxu Chen <bingxche@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On MI300/MI325, SGLang converts checkpoint FP8 weights to the FP8 form used by the GPU. That conversion creates a new scale tensor and drops the small label that says whether the scale holds normal numbers or raw UE8M0 bytes. Later code reads the missing label and crashes before DeepSeek can start.
Seen in https://github.com/sgl-project/sglang/actions/runs/34070685413/job/101587367851

.
Modifications
This keeps non-FNUZ paths unchanged and preserves the UE8M0 support added in #36805.
Accuracy Tests
Speed Tests and Profiling
Not applicable; this is a load-time condition fix.
Checklist
CI States
Latest PR Test (Base): ❌ Run #34242452181
Latest PR Test (Extra): ❌ Run #34242451829
Latest PR Test (AMD ROCm 10): ❌ Run #34242452279