Conversation
Collaborator
Author
|
/rerun-test test/registered/unit/disaggregation/test_prefill_abort_result_cleanup.py |
Contributor
|
Results for 🚀 |
Fridge003
merged commit Sep 6, 2026
926968b
into
xinyuan/glm-5.3-flash-support
83 of 91 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up to #36507, based on
xinyuan/glm-5.3-flash-support.CPU job 101456298849 fails all seven prefill-abort cleanup tests with
AttributeError: '_Scheduler' object has no attribute 'maybe_send_health_check_signal'.The tests introduced on main by #36988 instantiate only
SchedulerDisaggregationPrefillMixin. The GLM branch calls the real scheduler's health-check callback after processing a prefill result, so this test double needs that collaborator too.Modifications
Add
self.maybe_send_health_check_signal = Mock()to the test-only_Schedulerfixture. One line, one test file; no production changes, assertion changes, or registration changes.Validation
87de7ca9ba507093a276826aa83d52887793a4f8: all seven tests reproduce the missing-method failure.baizhou-nda, with all GPUs hidden.CUDA_VISIBLE_DEVICES=8 PYTHONPATH=python python3 test/registered/unit/disaggregation/test_prefill_abort_result_cleanup.py -f.git diff --checkpass./rerun-test: run 34023683974 passed, testing commitb7805652b9b633c0c54661b9918d0004e7dd6ca2onubuntu-latest. All seven tests passed; CPU job completed in 1m19s. No full CI requested.Accuracy Tests
Not applicable: test-fixture-only change; all abort cleanup assertions are retained.
Speed Tests and Profiling
Not applicable: no runtime changes.
Checklist