Repository navigation
[diffusion] test: validate every repeated server request - #38185
Merged
mickqian merged 10 commits intoSep 7, 2026
Merged
Conversation
mickqian
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
JustinTong0323,
ping1jing2,
sogalin,
wisclmy0611,
yichiche and
zijiexia
as code owners
September 6, 2026 06:00
4 tasks done
This was referenced Sep 7, 2026
5 tasks
This was referenced Sep 17, 2026
This was referenced Sep 25, 2026
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
perf_repeat_requestsissued multiple requests but validated only the last output. This can hide a failing first request or leave request-to-request state corruption insufficiently checked. #38171 is an example of why repeated requests need coverage.Modifications
conftestand debug prints; keep failed-case results through teardown.Rebased onto
67e3ccda97e0e, which includes #38171. No production runtime changes: all changes are tests and documentation.Accuracy Tests
Final head
9f1a1af9ef622bd29d87e4e1fa836914d9c2b645, isolated H200 environment:The fixture integration test uses a real pytest subprocess, two test classes, and both passing and failing cases. It checks that all eight request records survive without leaking case-local state.
Real-server validation is not fully green. Prior to the fixture cleanup/rebase, both H3 cases completed both requests on 2x H200 with performance and VRAM checks enabled. Against the existing H100 video GT:
A resident-VAE control reproduced these video metrics; independent audio GT checks passed for all four control requests. Ref2va also fails CLIP on the second request. The cross-request output difference still needs investigation. H200 results do not establish whether H100 CI passes, and no GT or consistency thresholds were changed to hide these failures.
Speed Tests and Profiling
Pre-rebase 2x H200 measurements at
3dad316967e21, Python 3.12, PyTorch 2.13.0+cu130, Transformers 5.12.1, 4 seconds / 8 steps:All four requests passed the configured performance/VRAM checks. These are coverage measurements, not a claimed inference speedup or H100 baseline calibration. Existing server startup is reused; the two H3 cases each add one short request. Partition time estimates were increased accordingly.
Checklist
CI States
Latest PR Test (Base): ✅ Run #34083939361
Latest PR Test (Extra): ❌ Run #34083939239
Latest PR Test (AMD ROCm 7.2): ⏳ Run #34083939346