Skip to content

fix: preserve SWA host lock on node split - #38138

Merged
alphabetc1 merged 3 commits into
sgl-project:mainfrom
alphabetc1:fix/unified-swa-host-split-lock
Sep 7, 2026
Merged

alphabetc1 merged 3 commits into
sgl-project:mainfrom
alphabetc1:fix/unified-swa-host-split-lock

Conversation

@alphabetc1

@alphabetc1 alphabetc1 commented Sep 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve SWA host-side lock refs when a host-backed SWA node is split.
  • Move the SWA host_uuid boundary to the split parent so release walks still cover both fragments.
  • Keep locked host-only SWA fragments out of the host LRU until the host lock is released.

Testing

  • python3 -m py_compile python/sglang/srt/mem_cache/unified_cache/components/swa_component.py
  • pre-commit run --files python/sglang/srt/mem_cache/unified_cache/components/swa_component.py

CI States

Latest PR Test (Base): ✅ Run #34040752126
Latest PR Test (Extra): ✅ Run #34040758011
Latest PR Test (AMD ROCm 7.2): ❌ Run #34040752082

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T15:44:47.309145Z e684fa7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alphabetc1
alphabetc1 force-pushed the fix/unified-swa-host-split-lock branch from e684fa7 to 6dd113f Compare September 5, 2026 16:06
@alphabetc1

Copy link
Copy Markdown
Collaborator Author

/rerun-group radix_cache/unified_radix_tree

@github-actions

github-actions Bot commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Results for /rerun-group radix_cache/unified_radix_tree:

🚀 4-gpu-h100 (5 tests): ✅ View workflow run

cd test/ && python3 registered/radix_cache/unified_radix_tree/linker/test_unified_cache_linker_kl_dsv4.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_hicache_pp_kl.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_cp.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_dsv4.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_mamba.py

🚀 8-gpu-h200 (4 tests): ✅ View workflow run

cd test/ && python3 registered/radix_cache/unified_radix_tree/linker/test_unified_cache_linker_kl_glm52.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_dsv4_pp.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_glm52.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_mimo.py

🚀 4-gpu-b200 (1 test): ❌ View workflow run

cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_dcp.py

🚀 2-gpu-h100 (2 tests): ✅ View workflow run

cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_full.py
cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_swa.py

🚀 1-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/radix_cache/unified_radix_tree/test_unified_radix_cache_kl_hybrid_bitexact.py

@alphabetc1 alphabetc1 added the run-ci CI: run the baseline test suite on this PR label Sep 6, 2026
@alphabetc1
alphabetc1 merged commit f258489 into sgl-project:main Sep 7, 2026
212 of 253 checks passed
@alphabetc1
alphabetc1 deleted the fix/unified-swa-host-split-lock branch September 7, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass-fastfail run-ci CI: run the baseline test suite on this PR unified-radix-cache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants