Repository navigation
fix: preserve SWA host lock on node split - #38138
Merged
alphabetc1 merged 3 commits intoSep 7, 2026
Merged
Conversation
alphabetc1
requested review from
Ying1123,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
September 5, 2026 15:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alphabetc1
force-pushed
the
fix/unified-swa-host-split-lock
branch
from
September 5, 2026 16:06
e684fa7 to
6dd113f
Compare
Collaborator
Author
|
/rerun-group radix_cache/unified_radix_tree |
Contributor
|
Results for 🚀 🚀 🚀 🚀 🚀 |
ispobock
approved these changes
Sep 6, 2026
Merged
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host_uuidboundary to the split parent so release walks still cover both fragments.Testing
python3 -m py_compile python/sglang/srt/mem_cache/unified_cache/components/swa_component.pypre-commit run --files python/sglang/srt/mem_cache/unified_cache/components/swa_component.pyCI States
Latest PR Test (Base): ✅ Run #34040752126
Latest PR Test (Extra): ✅ Run #34040758011
Latest PR Test (AMD ROCm 7.2): ❌ Run #34040752082