Conversation
Fridge003
marked this pull request as ready for review
September 4, 2026 23:08
Fridge003
requested review from
1am9trash,
BBuf,
DarkSharpness,
HaiShaw,
HydraQYH,
Qiaolin-Yu,
YAMY1234,
celve,
hebiao064,
hubertlu-tw,
ispobock,
kkHuang-amd,
merrymercy,
rainj-me and
yuan-luo
as code owners
September 4, 2026 23:08
Fridge003
merged commit Sep 4, 2026
f079686
into
xinyuan/glm-5.3-flash-support
78 of 87 checks passed
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #36507 (
xinyuan/glm-5.3-flash-support, based769a1d265b8c732b72b946b6ba2a16ae1d85815). Remove the experimental metadata optimizations while retaining GLM-5.3 Flash's No-RoPE, KPool, EAGLE, and TileLang/FA3 fallback support.This should be added back after clean up.
Modifications
SGLANG_EXPERIMENTAL_DSA_KPOOL_METADATA_FUSIONSGLANG_EXPERIMENTAL_DSA_INGRAPH_VERIFY_METADATASGLANG_EXPERIMENTAL_DSA_INGRAPH_VERIFY_METADATA_DG_OUT_OF_GRAPHdsa_backend.pyis reduced by 480 lines. No changes to the model forward math or No-RoPE/TRTLLM/TileLang/FA3 dispatch paths.Accuracy Tests
GPU validation at
62f4493387(before the follow-up deletion of the warning-only registry entries/test), on temporary rx devboxcodex-glm53-metadata-trim: 1x NVIDIA H200, driver 580.105.08, PyTorch 2.13.0+cu130.Additional checks:
Full GLM model/GSM8K e2e was not rerun for this removal. No full CI or
run-ciwas requested; validation was confined to the devbox tests above.Speed Tests and Profiling
No new speed benchmark. This intentionally removes optional acceleration: workloads that enabled these options lose those optimizations, and reverting the shared bounded-scan/preallocated-plan changes can increase metadata overhead (especially large-context non-KPool workloads). Accuracy thresholds and serving configurations are unchanged.
Checklist
CI States
Latest PR Test (Base): ❌ Run #33928287001
Latest PR Test (Extra): ❌ Run #33928286867
Latest PR Test (AMD ROCm 7.2): ❌ Run #33928287067