-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Diffusion] Cache-DiT 1.5.1: DMD Calibrator, SVDQuant DQ, etc. #37774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DefTruth
wants to merge
24
commits into
sgl-project:main
Choose a base branch
from
xlite-dev:cache-dit-1.5.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b10d333
upgrade cache-dit -> 1.5.0
DefTruth c1884b7
upgrade cache-dit -> 1.5.0
DefTruth 2c3ac64
update
DefTruth 1890bac
upgrade cache-dit -> 1.5.1
DefTruth c0e38b7
test: cover DMD calibrator knobs and TaylorSeer exclusivity
DefTruth de728a7
chore: update .gitignore
DefTruth 8225cd7
diffusion: add sglang-diffusion-cache-dit skill
DefTruth 51c3b41
Merge branch 'main' into cache-dit-1.5.1
DefTruth 5f01700
Fix Cache-DiT skill markdown lint
BBuf 0b1164b
Merge pull request #1 from BBuf/fix-pr-37774-lint
DefTruth 5b2628d
Merge branch 'main' into cache-dit-1.5.1
DefTruth 29d2984
diffusion: update dmd calibrator and svdq-dq docs
DefTruth 7b04a12
skills: update skills
DefTruth af77d72
Merge branch 'main' into cache-dit-1.5.1
DefTruth 14211a0
[Diffusion] Keep cache-dit integration importable with cache-dit < 1.5.0
DefTruth 7095951
Merge branch 'main' into cache-dit-1.5.1
DefTruth c057794
Merge branch 'main' into cache-dit-1.5.1
DefTruth c9b22eb
Merge branch 'main' into cache-dit-1.5.1
DefTruth 9054938
Merge branch 'main' into cache-dit-1.5.1
DefTruth 9fefa7f
Merge branch 'main' into cache-dit-1.5.1
DefTruth 294fdb3
Merge branch 'main' into cache-dit-1.5.1
DefTruth 5151b23
Merge branch 'main' into cache-dit-1.5.1
DefTruth 323aa02
Merge branch 'main' into cache-dit-1.5.1
DefTruth 5fb7afd
Merge branch 'main' into cache-dit-1.5.1
DefTruth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Apply the cache-dit upgrade to Base jobs that import diffusion modules. This pin is under the
diffusionextra, butbase-b-test-1-gpu-small (1)invokesci_install_dependency.shwithout that extra and installspython[dev,runai,tracing]. On this exact head, its package list still reportscache-dit 1.3.0; importingtest/registered/unit/models/test_qwen_image_fp8_norm_quant.pythen reaches the new top-level imports incache_dit_integration.pyand fails withImportError: cannot import name 'BlockAdapterRegister' from 'cache_dit'(failed job). Please make the Base installation path install the required Cache-DiT version before running these tests, and cover the real package/import boundary with a smoke test. The Cache-DiT unit tests add these exports to a stub, so they cannot detect the installed-package mismatch. Rerunning alone does not ensure that this dependency is upgraded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out this error. This really needs to be fixed. We do need to consider compatibility with other cases where cache-dit hasn't been upgraded to 1.5.1. I'm working on this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you prefer to upgrade all scenarios to cache-dit 1.5.1, or only upgrade python/pyproject.toml first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickqian fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing these CI failures caused by this:
https://github.com/sgl-project/sglang/actions/runs/34321708659/job/102392704016?pr=38426
https://github.com/sgl-project/sglang/actions/runs/34334438529/job/102430646325?pr=35599
Root cause: