Skip to content

[nixl staging buffer] fix decode hung issue when multiple chunks arrived out of order #37697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fteng-NV wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[nixl staging buffer] fix decode hung issue when multiple chunks arrived out of order #37697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions python/sglang/srt/disaggregation/nixl/conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2517,12 +2517,14 @@ def _track_kv_arrival(
self.transfer_statuses[room].num_pp_ranks_expected = (
self.required_prefill_response_num_table.get(room, 1)
)
if (
self.enable_staging
and self._staging_handler is not None
and self._staging_handler.is_staging_room(room)
):
self._maybe_submit_last_scatter(room)
# Staging may defer chunks, so an earlier chunk can arrive after the last one.
# any arrival chunk maybe the last for scatter.
if (
self.enable_staging
and self._staging_handler is not None
and self._staging_handler.is_staging_room(room)
):
self._maybe_submit_last_scatter(room)

def _track_kv_part_arrival(
self,
Expand Down
Loading