Repository navigation
[LoRA] Restore GDN in_proj target-module choices lost in the rebase - #37466
Merged
yueming-yuan merged 1 commit intoSep 1, 2026
Merged
Conversation
yueming-yuan
force-pushed
the
yueming/restore-gdn-lora-target-choices
branch
from
September 1, 2026 19:47
05ffbcc to
b185a44
Compare
Kh4L
pushed a commit
to Kh4L/sglang
that referenced
this pull request
Sep 8, 2026
…gl-project#37466) (cherry picked from commit 98bb145)
8 of 33 tasks
HJSang
pushed a commit
to HJSang/sglang
that referenced
this pull request
Sep 21, 2026
…gl-project#37466) (cherry picked from commit 98bb145)
ziang-and
pushed a commit
to zianglih/sglang
that referenced
this pull request
Oct 2, 2026
…30499, sgl-project#37466, sgl-project#37887) Co-authored-by: fzyzcjy <ch271828n@outlook.com> Co-authored-by: yueming-yuan <yym022502@gmail.com>
nv-hwoo
pushed a commit
to nv-hwoo/sglang
that referenced
this pull request
Oct 20, 2026
…30499, sgl-project#37466, sgl-project#37887) Co-authored-by: fzyzcjy <ch271828n@outlook.com> Co-authored-by: yueming-yuan <yym022502@gmail.com>
Rockdu
pushed a commit
that referenced
this pull request
Oct 30, 2026
Rockdu
pushed a commit
that referenced
this pull request
Oct 30, 2026
Rockdu
pushed a commit
that referenced
this pull request
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.5.19 rebase of sglang-miles dropped
in_proj_qkvz/in_proj_bafromSUPPORTED_LORA_TARGET_MODULES(the Inkling entriesqkvr/wo_udwere carried over, the GDN ones were not). The runtime support is intact —lora.pystill ships_normalize_in_proj_qkvz/_normalize_in_proj_ba— only the argparse choices went missing, so any--lora-target-modules in_proj_qkvzlaunch dies at ServerArgs parsing.miles' GDN LoRA converter emits exactly these names (
in_proj -> [in_proj_qkvz, in_proj_ba], used by the Qwen3.5-35B-A3B LoRA recipe on miles main), and miles CPU CI installs this branch's tip, so every miles PR currently failsTestLoraTargetModules::test_gdn_attention_targets_are_named_one_by_one.Verified: with the two entries restored, that miles test class passes 5/5 (fails 1/5 without).
CI States
Latest PR Test (Base): ❌ Run #33551572792
Latest PR Test (Extra): ❌ Run #33551572623
Latest PR Test (AMD ROCm 7.2): ❌ Run #33551572745