Repository navigation
[Diffusion][RL] Reuse disk LoRA mapping and FFN swap on H3 IPC updates - #37350
Merged
Zhichenzzz merged 3 commits intoSep 9, 2026
Merged
Conversation
Export swap_peft_swiglu_fc1_lora_b so IPC writes reuse the same [value; gate] → [gate; value] rewrite as disk load_lora_adapter. On miles-h3, resolve also probes the LoRA suffix the disk mapping already understands.
niehen6174
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
mickqian,
ping1jing2 and
yichiche
as code owners
September 1, 2026 05:11
Merged
1 task
Zhichenzzz
approved these changes
Sep 9, 2026
Zhichenzzz
merged commit Sep 9, 2026
859a278
into
sgl-project:sglang-miles-h3
81 of 90 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--lora-path.lora_Bswap ([value; gate]→[gate; value]) on IPC writes.*.lora_Asuffix the disk mapping already understands.ff.net.0.proj→ nativemlp.fc1.Test plan
pytest python/sglang/multimodal_gen/test/unit/test_fused_lora_compose.py::test_h3_ipc_reuses_disk_mapping_and_ffn_swapCI States
Latest PR Test (Base): ❌ Run #33472749295
Latest PR Test (Extra): ❌ Run #33472749167
Latest PR Test (AMD ROCm 7.2): ❌ Run #33472749258