test(spec): cover speculative TP synchronization contract - #37264
Open
seongyun1104 wants to merge 1 commit into
Open
seongyun1104 wants to merge 1 commit into
seongyun1104 wants to merge 1 commit into
Conversation
seongyun1104
marked this pull request as ready for review
September 1, 2026 09:09
Author
|
Ready for review. The earlier matrix was blocked only because the PR was draft; upstream lint passed, and the focused parser/broadcast suite passes 10/10 locally. Could a maintainer please authorize the registered Linux CI when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SGLANG_SPEC_TP_SYNCparser, presets, numeric/sluggified selectors, and negationWhy
SpecTpSyncprotects DSpark and DFlash decisions that must stay identical across TP ranks, including graph-tier planning and acceptance state. The helper currently has no direct unit coverage, so a parser/default regression or an accidental single-rank collective could silently weaken that correctness boundary.Validation
ruff check test/registered/unit/spec/test_spec_tp_sync.pyruff format --check test/registered/unit/spec/test_spec_tp_sync.pypython3 -m py_compile test/registered/unit/spec/test_spec_tp_sync.pyRepository-level pytest collection was unavailable on the local macOS host because SGLang imports Triton during package initialization. The PR is ready for the registered Linux CPU test once project CI is authorized.
CI States
Latest PR Test (Base): ❌ Run #33407379655
Latest PR Test (Extra): ❌ Run #33407379145
Latest PR Test (AMD ROCm 7.2): ❌ Run #33407379685