Repository navigation
[mem_cache] Keep req.kv non-optional and key KV ownership on req_pool_idx - #36958
Merged
Merged
Conversation
hnyls2002
requested review from
ByronHsu,
Duyi-Wang,
HaiShaw,
ShangmingCai,
Ying1123,
alphabetc1,
hanming-lu,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
sogalin,
xiezhq-hermann and
yizhang2077
as code owners
August 29, 2026 03:52
hnyls2002
added
run-ci
3 of 5 tasks
hnyls2002
changed the title
req.kv non-optional and key KV ownership on req_pool_idxreq.kv non-optional and key KV ownership on req_pool_idx
Open
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep
req.kvon theReqfor its whole lifetime (zeroed viamark_released()instead of set toNone) and makereq_pool_idx is not Nonethe single "holds KV" predicate; the row and the KV bookkeeping were already allocated and released together, so the threeif req.kv is Noneallocation branches collapse and the lifecycle asserts become(not is_holding_kv) == kv.is_released.CI States
Latest PR Test (Base): 🚫 Run #33239319738
Latest PR Test (Extra): 🚫 Run #33239319651
Latest PR Test (AMD ROCm 7.2): 🚫 Run #33239319766