[Spec] Publish the final multi-layer EAGLE shared-read event - #36752
Merged
Qiaolin-Yu merged 3 commits intoSep 2, 2026
Merged
Conversation
Record shared-read completion after the final draft graph replay and expose the final draft runner as the scheduler WAR barrier owner. Cover both per-step and single-graph replay paths.
paulzhang-tm
requested review from
Qiaolin-Yu,
Ying1123,
hnyls2002 and
merrymercy
as code owners
August 27, 2026 23:59
5 tasks
Qiaolin-Yu
approved these changes
Sep 1, 2026
This was referenced Sep 4, 2026
StevenChenSE
pushed a commit
to StevenChenSE/sglang
that referenced
this pull request
Sep 6, 2026
…ject#36752) Co-authored-by: Qiaolin-Yu <liin1211@outlook.com>
paulzhang-tm
added a commit
to paulzhang-tm/sglang
that referenced
this pull request
Sep 9, 2026
…gl-project#36752)" This reverts commit 3fa6b86.
paulzhang-tm
added a commit
to paulzhang-tm/sglang
that referenced
this pull request
Sep 9, 2026
Resolve shared attention and conv-slot mappings into draft-owned buffers before target verification. Preserve the final-draft-runner fallback introduced in sgl-project#36752.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Multi-layer EAGLE does not publish the final draft graph's shared-read completion event, so the overlap scheduler falls back to a broader forward-stream fence.
Modifications
shared_read_done_eventafter the final draft step.Tests
CI States
Latest PR Test (Base): 🚫 Run #33448171148
Latest PR Test (Extra): ❌ Run #33448170895
Latest PR Test (AMD ROCm 7.2): ❌ Run #33448171383