Conversation
The qwen4-main-squashed branch fails CI lint because it was never run through the repo's pre-commit hooks. Formatting only, applied by `pre-commit run --all-files`; no behaviour change.
cshintov
requested review from
Alisehen,
AniZpZ,
BBuf,
ByronHsu,
Edwardf0t1,
FlamingoPg,
Fridge003,
HaiShaw,
JustinTong0323,
OrangeRedeng,
Qiaolin-Yu,
Ying1123,
alphabetc1,
b8zhong,
ch-wan,
hanming-lu,
hebiao064,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
mickqian,
mmangkad,
xiezhq-hermann,
yctseng0211,
yhyang201,
yizhang2077 and
yuan-luo
as code owners
August 27, 2026 09:34
cshintov
requested review from
DarkSharpness,
Duyi-Wang,
HydraQYH,
ShangmingCai,
celve and
sogalin
as code owners
August 27, 2026 09:34
5 tasks
yhyang201
merged commit Aug 28, 2026
71946eb
into
sgl-project:qwen4-main-squashed
81 of 90 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
qwen4-main-squashedbranch currently fails thelintCI job: it was never run through the repo's own pre-commit hooks.This applies
pre-commit run --all-filesusing the repo's.pre-commit-config.yaml(unchanged, pinned versions). Formatting only, no behaviour change: line wrapping, blank lines, import ordering, clang-format reflow of a few.cuhfiles.Hooks run: all pre-commit-hooks checks, isort 7.0.0, ruff v0.15.1, black-jupyter 26.1.0, codespell, clang-format v20.1.7, nbstripout, and the local
scripts/lint/*checkers. Second pass is clean.Skipped: the four Rust hooks (
rustfmt-sgl-model-gateway,rustfmt-sgl-router,clippy-rust-workspace,rustfmt-rust-workspace) — they need a cargo/rustup toolchain that isn't available here, and no Rust file is touched by this PR.No functional edits. In particular the
is_sm100_supported()gate in_resolve_trtllm_sparse_decodeis left exactly as it is on the base branch; the fix for that lives in #36649.CI States
Latest PR Test (Base): ❌ Run #33059174503
Latest PR Test (Extra): ❌ Run #33059174361
Latest PR Test (AMD ROCm 7.2): ❌ Run #33059174475