Repository navigation
[NPU] [bugfix] Fix import of ggml_moe_a8_vec and Fix NPU MLA HiCache backup accessing missing data_ptrs - #36640
Merged
Merged
Conversation
chx96642264
requested review from
Alisehen,
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
HaiShaw,
OrangeRedeng,
Ying1123,
alphabetc1,
b8zhong,
ch-wan,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
mmangkad,
xiezhq-hermann and
yizhang2077
as code owners
August 27, 2026 07:00
sglang-npu-bot
approved these changes
Aug 27, 2026
Collaborator
|
/tag-and-rerun-ci |
chx96642264
force-pushed
the
fix_bug
branch
3 times, most recently
from
August 27, 2026 12:14
cf72d22 to
1ed8542
Compare
…backup accessing missing data_ptrs
sglang-npu-bot
approved these changes
Aug 27, 2026
Fridge003
approved these changes
Aug 27, 2026
Collaborator
|
The root fix is in #36529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #30393 generalized the MLA HiCache backup path to support packed target and draft KV buffers. However,
NPUMLATokenToKVPoolintentionally does not createdata_ptrs(it uses contiguous multi-layer K/V/index-K tensors for the NPU transfer kernel).And, Ascend NPU does not support
ggml_moe_a8_vecwhich insgl_kernel.Errors as follows:


Modifications
Accuracy Tests
use
DeepSeek-V2-Lite-W8A8testgsm8kSpeed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #33071938518
Latest PR Test (Extra): ❌ Run #33071938243
Latest PR Test (AMD ROCm 7.2): ❌ Run #33071938450