[CI vehicle, do not merge] config: raw-input ServerArgs follow-up series (#36618-#36622) - #36623
Closed
ch-wan wants to merge 6 commits into
Closed
[CI vehicle, do not merge] config: raw-input ServerArgs follow-up series (#36618-#36622)#36623ch-wan wants to merge 6 commits into
ch-wan wants to merge 6 commits into
Conversation
ch-wan
requested review from
Fridge003,
HaiShaw,
Jiminator,
JustinTong0323,
Qiaolin-Yu,
ShangmingCai,
Ying1123,
alexnails,
alphabetc1,
b8zhong,
fzyzcjy,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
jybsuper,
kpham-sgl,
lifuhuang,
liusy58,
merrymercy,
mickqian,
mmangkad,
pyc96,
xiezhq-hermann,
yctseng0211,
yhyang201,
yizhang2077,
yuan-luo and
yushengsu-thu
as code owners
August 27, 2026 05:12
This was referenced Aug 27, 2026
Collaborator
Author
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ch-wan
requested review from
Alisehen,
AniZpZ,
FlamingoPg,
OrangeRedeng,
iforgetmyname,
ping1jing2,
whybeyoung and
yichiche
as code owners
August 27, 2026 07:56
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…s own Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Placeholder commit. This branch exists only to run CI over the five PRs of the series in one go; it carries no change of its own and is not for merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is the CI vehicle for a five-PR series, not a change. Its branch
cheng/gc-ciis one empty placeholder commit on top of PR 5, so a run hereexercises all five commits at once against
main. Do not merge it.The series is the follow-up to the raw-input
ServerArgswork (#36250–#36255),based on
d1f14431fdf. Each PR builds on the previous one; review them in order:Together they finish moving resolution's answers off the record:
ServerArgsholds the operator's raw input, and what resolution decided lives in the
declarations and the published config bags. Review comments belong on the
individual PRs above, not here.
Modifications
One empty commit.
git diffagainst PR 5 is empty;git diffagainstmainisthe five PRs, which is the point of the vehicle.
Labels:
run-ci,run-ci-extra,bypass-fastfail.Accuracy Tests
No model-output change in the series: it moves where a configuration value is
read from, not what resolution decides. The equivalent check is a resolution dump
— every field's resolved value for 24 launch shapes, taken in both trees and
compared field by field:
0 differences across 24 shapes × 478 shared fields, against
d1f14431fdf.The one field the series has and the base does not is
grpc_worker_threads: onmain it is a public non-field slot assigned in
_handle_deprecated_args, andPR 1 makes it a declared field. Its value is 4 on both sides.
Every guard also runs at each commit of the series, not only at the head — a
PR that is green only on top of its successors is not reviewable on its own. The
set is the config guards plus every registered test the series touches, ~33 files
per boundary, all green.
No GPU accuracy run locally. That gap is what this vehicle exists to close.
Speed Tests and Profiling
No benchmark run, and none is expected to move: nothing in the series changes a
kernel, a schedule, or the shape of any batch. What changes is the source of a
configuration read — a published dataclass attribute instead of a process-group
getter or an accessor hop.
The one place that could have mattered is
torch.compile: gate helpers readparallel leaves inside compiled forwards, and
object.__getattribute__graph-breaks. That was measured rather than assumed — the reads the series
introduces trace under
torch.compile(fullgraph=True), pinned by a regressiontest.
Checklist
Review and Merge Process
This PR is not for merge. It is closed once the five member PRs land.
🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ⏳ Run #33110332487
Latest PR Test (Extra): ⏳ Run #33110383631
Latest PR Test (AMD ROCm 7.2): ❌ Run #33110332664