Skip to content

[CI vehicle, do not merge] config: raw-input ServerArgs follow-up series (#36618-#36622) - #36623

Closed
ch-wan wants to merge 6 commits into
mainfrom
cheng/gc-ci
Closed

[CI vehicle, do not merge] config: raw-input ServerArgs follow-up series (#36618-#36622)#36623
ch-wan wants to merge 6 commits into
mainfrom
cheng/gc-ci

Conversation

@ch-wan

@ch-wan ch-wan commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Motivation

This PR is the CI vehicle for a five-PR series, not a change. Its branch
cheng/gc-ci is one empty placeholder commit on top of PR 5, so a run here
exercises all five commits at once against main. Do not merge it.

The series is the follow-up to the raw-input ServerArgs work (#36250#36255),
based on d1f14431fdf. Each PR builds on the previous one; review them in order:

  1. config: resolution declares, and nothing writes a field #36618 — config: resolution declares, and nothing writes a field
  2. config: every handler declares its cuda-graph decisions #36725 — config: every handler declares its cuda-graph decisions (re-opened from config: every handler declares its cuda-graph decisions #36619, whose base branch was deleted by PR 1's merge)
  3. config: a parallel leaf with no live counterpart is read bare #36620 — config: a parallel leaf with no live counterpart is read bare
  4. config: a parallel size has one spelling; a patched scope declares its own #36621 — config: a parallel size has one spelling; a patched scope declares its own
  5. config: the record is not an object that gets passed around #36622 — config: the record is not an object that gets passed around

Together they finish moving resolution's answers off the record: ServerArgs
holds the operator's raw input, and what resolution decided lives in the
declarations and the published config bags. Review comments belong on the
individual PRs above, not here.

Modifications

One empty commit. git diff against PR 5 is empty; git diff against main is
the five PRs, which is the point of the vehicle.

Labels: run-ci, run-ci-extra, bypass-fastfail.

Accuracy Tests

No model-output change in the series: it moves where a configuration value is
read from, not what resolution decides. The equivalent check is a resolution dump
— every field's resolved value for 24 launch shapes, taken in both trees and
compared field by field:

0 differences across 24 shapes × 478 shared fields, against d1f14431fdf.

The one field the series has and the base does not is grpc_worker_threads: on
main it is a public non-field slot assigned in _handle_deprecated_args, and
PR 1 makes it a declared field. Its value is 4 on both sides.

Every guard also runs at each commit of the series, not only at the head — a
PR that is green only on top of its successors is not reviewable on its own. The
set is the config guards plus every registered test the series touches, ~33 files
per boundary, all green.

No GPU accuracy run locally. That gap is what this vehicle exists to close.

Speed Tests and Profiling

No benchmark run, and none is expected to move: nothing in the series changes a
kernel, a schedule, or the shape of any batch. What changes is the source of a
configuration read — a published dataclass attribute instead of a process-group
getter or an accessor hop.

The one place that could have mattered is torch.compile: gate helpers read
parallel leaves inside compiled forwards, and object.__getattribute__
graph-breaks. That was measured rather than assumed — the reads the series
introduces trace under torch.compile(fullgraph=True), pinned by a regression
test.

Checklist

Review and Merge Process

This PR is not for merge. It is closed once the five member PRs land.

🤖 Generated with Claude Code


CI States

Latest PR Test (Base): ⏳ Run #33110332487
Latest PR Test (Extra): ⏳ Run #33110383631
Latest PR Test (AMD ROCm 7.2): ❌ Run #33110332664

@ch-wan

ch-wan commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: adaa12d58b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ch-wan and others added 6 commits August 27, 2026 19:44
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…s own

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Placeholder commit. This branch exists only to run CI over the five PRs of the
series in one go; it carries no change of its own and is not for merge.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@ch-wan

ch-wan commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

The five member PRs landed on main (#36618, #36725, #36620, #36621, #36622). This vehicle has served its purpose; closing without merge as stated in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amd bypass-fastfail deepseek diffusion SGLang Diffusion documentation Improvements or additions to documentation hicache Hierarchical Caching for SGLang lora Multi-modal multi-modal language model npu run-ci run-ci-extra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant