Skip to content

GLM-5.3-Flash cookbook: default Blackwell recipes to FP8 KV + TRT-LLM DSA - #36519

Merged
ShangmingCai merged 7 commits into
sgl-project:mainfrom
JustinTong0323:docs/glm53-fp8kv-default
Aug 26, 2026
Merged

ShangmingCai merged 7 commits into
sgl-project:mainfrom
JustinTong0323:docs/glm53-fp8kv-default

Conversation

@JustinTong0323

@JustinTong0323 JustinTong0323 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Follow-up to #36513 (merged) — the default-switch commit missed that squash. Since then three more issues surfaced in the published cookbook, so this PR now carries the full corrective batch:

  1. FP8 KV + TRT-LLM is a strict win (+2.3-5.5% throughput, ~1.8x KV capacity, GSM8K 97.35% vs 97.50% within noise) but is not the default — this PR makes it the Blackwell default.
  2. Every published cell was missing --disable-shared-experts-fusion — with fusion ON the model silently degenerates on the final weights (empty content, repetition loops, never stops). Isolation on 4x GB300: identical serves, only this flag differs — ON degenerates, OFF answers and stops. Every measured serve behind the published numbers ran with the flag.
  3. HiCache + MTP crashes at startup (AttributeError: DSATokenToKVPool has no attribute full_kv_pool) — the HiCache options are disabled for Low Latency until the code fix lands (validation in flight). High Throughput keeps them.
  4. HiCache L1+L2 had no measurements — now recorded in the HT notes.

Modifications

  • Eight Blackwell cells default to --kv-cache-dtype fp8_e4m3 + TRT-LLM DSA; H100/H200 keep BF16 + TileLang (FP8 option disabled on Hopper, reseats automatically). isRecommendedSelection is hardware-conditional; GB300 shows verified for both pairings.
  • Restore --disable-shared-experts-fusion to all twelve cells.
  • HiCache L1+L2 / +L3 disabled with a reason for the Low Latency strategy.
  • HT notes: disclose the extra flags the measured servers needed; record the HiCache L1+L2 overhead (BF16 1,125.45/2,403.57/3,839.57 and FP8 1,187.13/2,464.89/3,941.37 tok/s at conc 16/64/256, ≤1.2% below non-HiCache rows; random workload, so this bounds overhead, not L2 benefit).
  • HT FP8 card gains its measured accuracy (97.35%, 99.92% stop); Precision row, badge legend (in-progress), FP8 hint, pairing section, and the Reproduce modal summary (now shows the pairing) aligned.

Tests

  • Fusion isolation matrix on 4x GB300 final weights: ON degenerate / OFF pass.
  • 12/12 composed-command assertions (Blackwell default carries fp8+trtllm, Hopper reseats to bf16, no stray flags on switch-back).
  • GSM8K 1319: BF16 97.50% (100% stop), FP8 97.35% (99.92% stop).
  • HiCache L1+L2 both pairings: startups clean, 18/18 bench runs exit 0, sanity answers correct.
  • node docs/scripts/check_cookbook_configs.mjs — OK; mint validate — passed.

CI States

Latest PR Test (Base): ⏳ Run #32991107873
Latest PR Test (Extra): ⏳ Run #32991107656
Latest PR Test (AMD ROCm 7.2): ➖ No AMD PR run found for this commit.

… DSA

Measured on final weights at the rc2 cut: faster on every row (LL +3.5%,
HT +2.3-5.5%), 1.8x KV token capacity at identical pool bytes, GSM8K
within noise (97.35 vs 97.50). The eight Blackwell cells carry the fp8 /
trtllm flags; H100 and H200 stay on BF16 + TileLang, where the fp8
option is disabled and the panel reseats the default onto BF16. The
gb300 cells report Verified for either pairing since both were measured.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 26, 2026
- HT FP8 card: add the measured accuracy (GSM8K 97.35%, 99.92% stop) and
  drop the stale not-re-run claim.
- HT BF16 notes: disclose the full extra flag set the measured servers
  used (the conc 64/256 rows need them; the cell's automatic sizing is
  not enough).
- Precision row: FP8 KV default on Blackwell, BF16 KV on H100/H200.
- Badge legend: cover the in-progress state; refresh the FP8 pairing hint.
- Reproduce modal summary includes the KV/DSA pairing so the BF16 and
  FP8 cards read differently.
…ery cell

Without it (shared-experts fusion on) the model degenerates on the final
weights: empty content, verbatim loops, never stops — isolated on 4x
GB300 with the fusion flag as the only difference. Every measured serve
behind the published numbers ran with the flag; the minimal-flags trim
dropped it by mistake.
Both pairings measured with a 32 GB host tier on the final weights:
BF16 + TileLang 1,125.45 / 2,403.57 / 3,839.57 and FP8 + TRT-LLM
1,187.13 / 2,464.89 / 3,941.37 output tok/s at concurrency 16 / 64 / 256
— at most 1.2% below the non-HiCache rows. The random workload never
reuses prefixes, so these numbers bound the L2 overhead, not its benefit.
…n flag

Both Low Latency rows now come from servers running
--disable-shared-experts-fusion, matching the published cells: BF16
1,812.86 tok/s (-0.5% vs the fusion-on measurement) and FP8 1,870.82
tok/s (-0.8%); TPOT unchanged, FP8 stays 3.2% ahead. The flag costs
nothing measurable on throughput.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants