-
Notifications
You must be signed in to change notification settings - Fork 9.3k
[Bugfix] Support root JSON Schema combinators in tool parsers #36483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
xeophon
wants to merge
7
commits into
sgl-project:main
from
xeophon:fix/root-json-schema-tool-parsers
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ebe3a65
fix: support root JSON Schema combinators in tool parsers
xeophon c14cd5e
fix: resolve local refs in root schema combinators
xeophon 1ec852e
fix: resolve refs in projected property schemas
xeophon 00ca197
fix: preserve unconstrained tool argument strings
xeophon 7224bca
fix: preserve root schema branch streaming
xeophon 884beac
fix: find alternatives beneath allOf
xeophon 3018725
fix: project root combinator properties for tool parsers
xeophon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When every
anyOf/oneOfbranch declares the same argument as an object or array but applies different nested constraints, the schemas are unequal and this collapses the property hint to{}. Detectors such as Qwen then inferstring, so a valid nested argument remains JSON-encoded text even though every alternative agrees on its container type—a common case for discriminated unions with branch-specific payload fields. Combine the candidate schemas under the relevant combinator, or at least preserve their common inferred type, instead of requiring exact schema equality.Useful? React with 👍 / 👎.