Repository navigation
Support speculative decoding with unified SWA memory - #36403
Merged
merrymercy merged 4 commits intoSep 3, 2026
Merged
Conversation
ZYHowell
requested review from
Fridge003,
Ying1123,
alphabetc1,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
August 26, 2026 01:05
Collaborator
Author
|
/tag-and-rerun-ci |
github-actions
Bot
added
unified-radix-cache
memory-pool
run-ci
hanming-lu
approved these changes
Aug 26, 2026
Collaborator
Author
|
/rerun-failed-ci |
12 similar comments
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
Collaborator
Author
|
/rerun-failed-ci |
1 similar comment
Collaborator
Author
|
/rerun-failed-ci |
This was referenced Aug 27, 2026
merrymercy
force-pushed
the
yonghao/unified-memory-spec-decoding
branch
2 times, most recently
from
September 1, 2026 20:06
2860a0d to
8aa7f2f
Compare
Co-authored-by: Yonghao Zhuang <yhzhuang@meta.com>
ZYHowell
force-pushed
the
yonghao/unified-memory-spec-decoding
branch
from
September 1, 2026 22:04
8aa7f2f to
e887a18
Compare
merrymercy
reviewed
Sep 2, 2026
StevenChenSE
pushed a commit
to StevenChenSE/sglang
that referenced
this pull request
Sep 6, 2026
Co-authored-by: yhzhuang <yhzhuang@fb.com> Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Unified-memory hybrid-SWA targets need speculative draft pools to address the target allocator's full virtual-ID range even when the SWA pool has a smaller physical capacity. Without this, draft KV allocation and locked-node SWA recovery can use inconsistent mappings or under-size the shared pool.
Modifications
Accuracy Tests
Not applicable; this changes KV-pool allocation and mapping rather than model numerics.
Speed Tests and Profiling
Not run; no kernel or model-forward changes.
Test Plan
pytest -q test/registered/unit/model_executor/test_pool_configurator.py test/registered/unit/mem_cache/test_multi_ended_allocator.py test/registered/unit/mem_cache/test_unified_radix_cache_unittest.py— 1233 passed, 1115 skipped, 52 subtests passed.pre-commit run --files <six changed files>— passed.python3 -m py_compile <six changed files>— passed.Original commits
f70b8ee89Checklist
CI States
Latest PR Test (Base): ❌ Run #33701038576
Latest PR Test (Extra): ❌ Run #33701038383
Latest PR Test (AMD ROCm 7.2): ❌ Run #33701038531