[AMD][CI] Run only the ROCm 7.2.4 image on the nightly schedule - #36217
Draft
michaelzhang-ai wants to merge 3 commits into
Draft
michaelzhang-ai wants to merge 3 commits into
michaelzhang-ai wants to merge 3 commits into
Conversation
#35603 put both rocm724 and rocm720 on the 17:30 nightly. Over the four complete nights that followed (2026-08-20..23, 47 job pairs a night) the two legs agreed on 171 of 188 pairs, and only two jobs ever failed on rocm720 with rocm724 green -- each once, neither reproducing on the other three nights. The unique signal ran the other way: grok1-int4 failed on rocm724 three nights out of four while rocm720 stayed green. The second leg was not free. Every scheduled run since the merge was cancelled at the 24h mark by the next night's schedule, nightly-4-gpu produced a result in only two of eight leg-nights, and the untouched ROCm 7.0 nightly sharing the MI30x pools went the same way. Keep the schedule on rocm724, which is what the PR gate already defaults to, and leave rocm720 one dispatch away: pick it from the dropdown, or choose "all" for both. Co-authored-by: quitenode <quitenode@users.noreply.github.com>
michaelzhang-ai
marked this pull request as ready for review
August 24, 2026 21:28
michaelzhang-ai
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
August 24, 2026 21:28
Keep ROCm 7.2.0 coverage, but run it in a separate reusable-workflow call twelve hours away from the primary ROCm 7.2.4 schedule. Include the image flavor in the concurrency key so the two schedules cannot cancel each other. Teach the AMD job monitor and failure analyzer about the staggered workflow so both flavors remain visible in CI reports. Co-authored-by: quitenode <quitenode@users.noreply.github.com>
This reverts commit 26d80b6.
michaelzhang-ai
marked this pull request as draft
August 25, 2026 01:04
This was referenced Aug 25, 2026
This was referenced Sep 1, 2026
This was referenced Sep 9, 2026
alexnails
restored the
cursor/drop-rocm720-leg-from-amd-nightly-8403
branch
September 14, 2026 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#35603 put both
rocm724androcm720on the one 17:30 nightly. Four complete nights ran that way (2026-08-20 … 08-23, 47 job pairs a night) before #36171 changed the image-pull path. This PR makes the schedule runrocm724only, on cost and redundancy grounds.The 24-hour overruns on those four nights were not caused by the second leg. They were the shared local registry at
10.44.14.109:5000. On 08-22 a single MI30x job resolved its image at 00:27:35 and finisheddocker pullfrom the local registry at 03:33:50 — one successful pull, no fallback, 186 minutes. MI35x jobs never went down that path and held a 4.1 min median throughout, even though their job count doubled too, and the untouched ROCm 7.0 nightly on the same MI30x pools took the same 10x hit without changing its job count at all. With #36171 bypassing the local registry, tonight's run has both legs, an MI30xSetup dockermedian back at 14.9 min (max 18.8), and 86 of 92 jobs done in about 7.4 h. So both flavors do fit in a night now; the wall-clock argument for touching this workflow is gone.What remains is cost and redundancy.
Of 188 job pairs over the four nights, 166 reached the same completed verdict, 17 disagreed and 5 involved a cancellation. Only five job-nights had
rocm720fail whilerocm724passed, spread over four distinct jobs, and none reproduced on another night:nightly-8-gpu-mi35x-deepseek-r1-hicachenightly-8-gpu-mi35x-qwen35-triton-dcpnightly-8-gpu-minimax-m27nightly-accuracy-8-gpu-mi35xnightly-4-gpu-mi35x-minimax-m25No durable 7.2.0-specific regression appeared. The unique signal ran the other way:
nightly-8-gpu-grok1-int4failed on 724 three nights out of four while 720 stayed green all four, andgrok2,minimax-m3andglm5-mxfp4each had a 724-only failure. That is expected, sincerocm724is Ubuntu 24.04 / Python 3.12 / torch 2.11 / triton 3.7 against 720's 22.04 / 3.10 / 2.9.1, and it argues for keeping 724 rather than both. Tonight repeats the pattern: 9 failures on 724, 8 on 720.On cost, tonight's healthy run puts each leg at roughly 205–212 GPU-hours, so the second leg is about 210 GPU-hours a night.
Modifications
nightly-test-amd-rocm720.yml: therocm_versionmatrix resolves to["rocm724"]when no input is given, so thescheduleandpushtriggers run one leg.allstill expands to both.workflow_dispatchdefault moves fromalltorocm724, withrocm720andallstill in the dropdown. Theworkflow_calldefault was alreadyrocm724; its stale comment is corrected.amd-ci-job-monitor.yml:rocm_flavorsdrops torocm724, which that script is documented to keep in sync with the matrix.Verified that every trigger resolves as intended (
schedule/push→["rocm724"], dispatch default →["rocm724"], dispatchrocm720→["rocm720"], dispatch or callerall→ both), that no existing caller passesall(amd-aiter-scout,bot-bump-sglang-versionandrelease-branch-cutall take therocm724default), and thatcheck_workflow_job_names.py,actionlintand the full pre-commit set pass.Open question for AMD CI owners
This is a coverage-vs-cost call, not a fix for an outage, so it is reasonable to reject it.
rocm720images are still published nightly byrelease-docker-amd-rocm720-nightly.ymland still built for stable releases byrelease-docker-amd.yml, so after this change they have no scheduled coverage. Three ways to go:github.event.schedulein the concurrency group so the two crons do not cancel each other);Checklist
CI States
Latest PR Test (Base): ❌ Run #32796016068
Latest PR Test (Extra): ❌ Run #32796015960
Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.