Skip to content

[Weight Cache] Enhance test and support EPLB - #36198

Merged
alexnails merged 10 commits into
sgl-project:mainfrom
kvcache-ai:sunxun/weight-cache-static-dp-ep-pr0
Aug 27, 2026
Merged

alexnails merged 10 commits into
sgl-project:mainfrom
kvcache-ai:sunxun/weight-cache-static-dp-ep-pr0

Conversation

@UNIDY2002

@UNIDY2002 UNIDY2002 commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

As a follow-up of #33684, we added unit tests for the DP and EP layouts, and we also unblocked the EPLB feature.

cc: @liusy58 @alexnails

Modifications

  • Created TestWeightCacheDaemonQwen3MoeDP and TestWeightCacheDaemonQwen3MoeEP for tests
  • compute_initial_expert_location_metadata on daemon startup when EPLB is enabled

Accuracy Tests

CI should pass

Speed Tests and Profiling

N/A

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ⏳ Run #33040672726
Latest PR Test (Extra): ⏳ Run #33040672420
Latest PR Test (AMD ROCm 7.2): ⏳ Run #33040672645

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/tag-run-ci-label

@github-actions github-actions Bot added the run-ci CI: run the baseline test suite on this PR label Aug 24, 2026
@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/tag-and-rerun-ci extra

@github-actions github-actions Bot added the run-ci-extra CI: also run the extra suite (requires run-ci) label Aug 24, 2026
@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@liusy58

liusy58 commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks for your contribution! We should put together a summary table to track which combinations of args are covered by the weight cache daemon tests.

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

1 similar comment
@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

Should be fixed by #36424. Let's merge with main.

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/rerun-failed-ci

@UNIDY2002

This comment was marked as spam.

@github-actions

Copy link
Copy Markdown
Contributor

⛔ /rerun-test requires cooldown_interval_minutes: 0 in .github/CI_PERMISSIONS.json, or write permission on the repo.

Please ask a maintainer to run this command, or use the normal CI flow.

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

(Please ignore the above comment, which was performed by my agent...)

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

Cases related to our PR are all green:

The failed cases are irrelevant, and all failed for the same reason:

  • AttributeError: 'DeepseekV4ForCausalLMDSpark' object has no attribute 'sample_from_anchor'

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

Fixed a very small conflict with main in server_args.py.

Upstream changed from if self.weight_cache_mode != "off" and self.enable_eplb: to if cfg.weight_cache_mode != "off" and cfg.enable_eplb:

@liusy58

liusy58 commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

/rerun-test test/registered/model_loading/test_weight_cache_daemon.py
/rerun-test test/registered/unit/model_loader/test_weight_cache_protocol.py
/rerun-test test/registered/unit/server_args/test_server_args.py

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/model_loading/test_weight_cache_daemon.py:

🚀 2-gpu-h100 (1 test): ❌ View workflow run

cd test/ && python3 registered/model_loading/test_weight_cache_daemon.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/model_loading/test_weight_cache_daemon.py

@UNIDY2002

Copy link
Copy Markdown
Contributor Author

/rerun-test test/registered/model_loading/test_weight_cache_daemon.py

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/model_loading/test_weight_cache_daemon.py:

🚀 2-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/model_loading/test_weight_cache_daemon.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/model_loading/test_weight_cache_daemon.py

@alexnails alexnails left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexnails
alexnails merged commit adcf73d into sgl-project:main Aug 27, 2026
116 of 185 checks passed
@UNIDY2002
UNIDY2002 deleted the sunxun/weight-cache-static-dp-ep-pr0 branch August 27, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass-fastfail run-ci CI: run the baseline test suite on this PR run-ci-extra CI: also run the extra suite (requires run-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants