[AMD] Disable DSA dense decode graphs with DP attention - #36079
Open
taking-lying-flat wants to merge 1 commit into
Open
taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
taking-lying-flat
requested review from
Fridge003,
Ying1123,
hnyls2002,
ispobock and
merrymercy
as code owners
August 23, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
#31324 automatically enabled a dense k-only graph for DSA decode when
max_kv_len <= index_topk. As isolated in #36071, replaying that graph on GLM-5.2 with DP attention can produce all-NaN logits on every attention-TP rank. The same topology is clean with eager decode and with the full-indexer graph, including when MTP and overlap scheduling are disabled.This change applies the narrow correctness guard requested in #36071. It does not attempt to claim or mask a root-cause fix for the HIP k-only graph; that path should be re-enabled with DP attention only after its capture/replay buffer and stream contracts are qualified on the affected hardware.
Scope
Fixes #36071