Skip to content

[Diffusion] Load serialized Comfy W4A8 checkpoints - #36036

Merged
mickqian merged 1 commit into
mainfrom
codex/diffusion-kitchen-w4a8
Aug 24, 2026
Merged

mickqian merged 1 commit into
mainfrom
codex/diffusion-kitchen-w4a8

Conversation

@mickqian

@mickqian mickqian commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • auto-detect Comfy asym_w4a8_int8 metadata from safetensors headers
  • validate packed INT4 weights, FP8 group scales, FP32 channel scales, codebooks, and optional correction tensors before model construction
  • load serialized W4A8 linears through Comfy Kitchen without requantization or an explicit --quantization flag
  • preserve TP/offload support when ConvRot group boundaries remain valid, and reject FSDP consistently with other Comfy layer-marked formats
  • document the MiniMax-H3 FL2VA/Ref2VA DiT override flow

This is checkpoint-driven only: users select the W4A8 file with --transformer-weights-path; --quantization remains reserved for online quantization of unquantized weights.

Validation

  • pre-commit run --all-files
  • added focused unit coverage for global Comfy metadata resolution and packed W4A8 parameter construction
  • inspected the remote safetensors headers for:
    • starsfriday/MiniMax-H3-w4a8 FL2VA (200 W4A8 layers)
    • Winnougan/MiniMax-H3-INT4_Convrot_ComfyUI FL2VA and Ref2VA (200 W4A8 layers each)
  • all three headers match the implemented weight/scale/codebook contract

Local unit tests were not run; they are left to CI per the diffusion development workflow.

Size

  • existing production files: +114 / -2
  • new production files: 281 lines
  • tests and docs: 91 lines

CI States

Latest PR Test (Base): ✅ Run #32680535211
Latest PR Test (Extra): ❌ Run #32680535066
Latest PR Test (AMD ROCm 7.2): ⏳ Run #32680535183

@mintlify

mintlify Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
lmsysorg 🟢 Ready View Preview Aug 23, 2026, 5:47 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@mickqian

Copy link
Copy Markdown
Collaborator Author

/tag-and-rerun-ci

@mickqian
mickqian force-pushed the codex/diffusion-kitchen-w4a8 branch from 230a2ed to b90c160 Compare August 24, 2026 01:40
@mickqian
mickqian merged commit 2d84de5 into main Aug 24, 2026
132 of 142 checks passed
@mickqian
mickqian deleted the codex/diffusion-kitchen-w4a8 branch August 24, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion documentation Improvements or additions to documentation quant LLM Quantization run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant