[GDN] remove XPU path of causal_conv1d_fn and causal_conv1d_update - #35775
Merged
Merged
Conversation
jiayisunx
requested review from
Fridge003,
HaiShaw,
Qiaolin-Yu,
hebiao064,
ispobock and
merrymercy
as code owners
August 21, 2026 01:55
Contributor
Author
|
/tag-and-rerun-ci |
5 tasks
mingfeima
approved these changes
Aug 24, 2026
6 tasks
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 31, 2026
nzr-niu
pushed a commit
to nzr-niu/sglang
that referenced
this pull request
Sep 1, 2026
jakki-amd
pushed a commit
to jakki-amd/sglang
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #34720.
There will be two backend for linear attention on XPU: triton and intel_xpu. Our plan:
For the triton backend, we always use triton kernels. That means we need to remove the standalong SYCL conv1d kernel from SGLang.
For the intel_xpu backend, we will use the fused SYCL GDN kernel (#33354)
Modifications
Remove the SYCL conv1d kernels and fallback to triton kernels.
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #32438029441
Latest PR Test (Extra): ✅ Run #32703340685
Latest PR Test (AMD ROCm 7.2): ❌ Run #32438029391