Repository navigation
Conversation
Snakinya
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
mickqian,
ping1jing2 and
yichiche
as code owners
August 20, 2026 06:18
Author
|
/tag-and-rerun-ci extra |
Contributor
|
Thanks @Snakinya. Closing this because you have 7 PRs open and none updated in 7 days, over our soft cap of 5 for idle PRs. Reopen the two or three you most want reviewed - a short active set moves faster than a long idle one. Some directories moved recently, so an older branch may need retargeting: |
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The RIFE interpolator currently loads
flownet.pklwithtorch.load(..., weights_only=False).Vulnerable code path:
python/sglang/multimodal_gen/runtime/postprocess/rife_interpolator.pyPoC shape:
torch.savecan execute pickle payloads whenframe_interpolation_model_pathpoints to attacker-controlled contentThis keeps checkpoint-triggered code execution reachable on the current
mainbranch.Modifications
_load_rife_state_dict()to load checkpoints withweights_only=Trueload_state_dictAccuracy Tests
N/A. This change only affects checkpoint loading safety.
Speed Tests and Profiling
N/A. The change does not affect inference kernels or forward logic.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciValidation run:
pytest --noconftest python/sglang/multimodal_gen/test/unit/test_rife_safe_load.py -qpython -m py_compile python/sglang/multimodal_gen/runtime/postprocess/rife_interpolator.py python/sglang/multimodal_gen/test/unit/test_rife_safe_load.pyCI States
Latest PR Test (Base): ❌ Run #32339082231
Latest PR Test (Extra): ❌ Run #32339081730
Latest PR Test (AMD ROCm 7.2): ❌ Run #32339082160