Conversation
YAMY1234
marked this pull request as ready for review
August 19, 2026 17:53
YAMY1234
requested review from
Qiaolin-Yu,
Ying1123,
hnyls2002 and
merrymercy
as code owners
August 19, 2026 17:53
Collaborator
Author
|
/tag-and-rerun-ci |
YAMY1234
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
ch-wan and
ispobock
as code owners
August 21, 2026 00:23
…-selected-row-logits-20260819
Qiaolin-Yu
reviewed
Aug 31, 2026
Qiaolin-Yu
approved these changes
Sep 1, 2026
chuyeh
added a commit
to chuyeh/sglang
that referenced
this pull request
Sep 3, 2026
Build on the graph-path implementation from sgl-project#35546 and retain only the incremental eager ROCm optimization, removing duplicated graph behavior and test coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
StevenChenSE
pushed a commit
to StevenChenSE/sglang
that referenced
this pull request
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During EAGLE draft extension under CUDA graph execution, the model computes full-vocabulary logits for every draft row even though the speculative worker only consumes selected per-request rows. The unnecessary LM-head rows increase graph time and temporary memory usage on the decode critical path.
Modifications
Accuracy Tests
Speed Tests and Profiling
extra_buffer, and CUDA graph tiers through batch 32.1065810637still performs four full-vocabulary projections per target step by design; this optimization only owns draft-extend graph10658.Output tokens/s/GPUis an engine-side pure-generation metric derived from the fixed-B28 target-step window, not a service-level AIPerf total-throughput metric.Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #33596531149
Latest PR Test (Extra): ❌ Run #33596530896
Latest PR Test (AMD ROCm 7.2): ❌ Run #33596531105