Repository navigation
[AMD] Recalibrate the Quark MXFP4 MoE GSM8K threshold 0.92 -> 0.89 - #35477
Closed
kangwangamd wants to merge 3 commits into
Closed
kangwangamd wants to merge 3 commits into
kangwangamd wants to merge 3 commits into
Conversation
TestFP8ToMXFP4MOETP1 scores mean 0.916 (min 0.898, max 0.926) over 10 runs on MI355X, so the 0.92 gate passes only about 1 run in 10. The original value was derived from the unquantized FP8 reference (~0.948) rather than measured on the requantized path.
edit typo
remove typo
This was referenced Aug 19, 2026
This was referenced Aug 27, 2026
This was referenced Sep 1, 2026
This was referenced Sep 9, 2026
This was referenced Sep 24, 2026
2 tasks done
This was referenced Oct 2, 2026
This was referenced Oct 9, 2026
This was referenced Oct 21, 2026
This was referenced Oct 30, 2026
Contributor
Author
|
Close — already applied in PR #41980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_quark_mxfp4.py::TestFP8ToMXFP4MOETP1::test_gsm8kfails most nights onstage-b-test-1-gpu-small-amd-mi35x-rocm720(example):The 0.92 threshold was set in #18182 given unquant FP8 ref abt ~0.948, an assumed quant buffer
Measure offline by MI355X m12-17
10 repeat runs
image
rocm/sgl-dev:v0.5.17-rocm720-mi35x-20260818,serving
Qwen/Qwen3-30B-A3B-Instruct-2507-FP8with same args(
--quantization quark_mxfp4 --context-length 3000 --tensor-parallel-size 1) andsame
run_evalcall (500 questions, 8-shot, 512 max tokens, para 128):see res below
in short Only 1 / 10 runs above 0.92.
Two runs hit on 0.9200, since the test uses
assertGreaterthese 2 fail as well0.89 clears the observed minimum with a small margin. The repo's
measured - 0.05convention would give 0.866, which is also defensible if a looser gate is preferred; I picked the tighter of the two so the test still catches a real regression.Scope
This is threshold calibration only, no behaviour change. The accuracy itself looks healthy for MXFP4 — 0.916 against a 0.948 bf16 reference is about 3 points of quantization loss, which is in line with the other classes in this file.
Measured on MI355X because that is the runner for this job. The same cluster is also reported on
pr-test-amd; if that leg runs different hardware the distribution there is unverified.Checklist
cc @fxmarty-amd (#18182 set this threshold) @ColinZ22
CI States
Latest PR Test (Base): ❌ Run #32243903869
Latest PR Test (Extra): ❌ Run #32243903752