Repository navigation
[Fix] Preserve model runner contracts in prefill CUDA graphs - #35452
Merged
Oasis-Git merged 3 commits intoSep 20, 2026
Merged
Conversation
aurickq
requested review from
Fridge003,
Ying1123,
hnyls2002,
ispobock and
merrymercy
as code owners
August 19, 2026 05:05
Contributor
Author
|
/tag-and-rerun-ci |
Collaborator
|
/rerun-failed-ci |
aurickq
force-pushed
the
aurick/prefill-cg-runner-contracts
branch
from
August 24, 2026 19:49
fde967f to
d8cc915
Compare
Collaborator
Collaborator
|
Based failed on known ci issue: https://github.com/sgl-project/sglang/actions/runs/32770385846/job/97633999335?pr=35452 |
Collaborator
|
/rerun-group cpu |
Contributor
|
Results for 🚀 |
Collaborator
|
/rerun-failed-ci |
1 similar comment
Collaborator
|
/rerun-failed-ci |
aurickq
force-pushed
the
aurick/prefill-cg-runner-contracts
branch
from
September 17, 2026 22:48
b819df5 to
48aa615
Compare
Collaborator
|
/rerun-failed-ci |
aurickq
force-pushed
the
aurick/prefill-cg-runner-contracts
branch
from
September 18, 2026 22:11
48aa615 to
0bea6e0
Compare
Collaborator
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PrefillCudaGraphRunner constructs new ForwardBatch objects for capture and replay. Those objects currently bypass ModelRunner.prepare_dummy_forward_batch, even though model runners use that hook to prepare graph-specific batch state. The runner also rebuilds LogitsProcessorOutput while trimming graph padding but drops customized_info.
Modifications
Accuracy Tests
No model math or kernels are changed.
Speed Tests and Profiling
Not applicable. The hooks run during graph setup/replay preparation, and the output change only preserves existing metadata.
Checklist
CI States
Latest PR Test (Base): ❌ Run #35505146165
Latest PR Test (Extra): ❌ Run #35505146680
Latest PR Test (AMD ROCm 10): ❌ Run #35505145958