[AMD] Perf Kimi-K3 low concurrency optimizations - #35287
kkHuang-amd wants to merge 8 commits into
Conversation
Vendor selected Kimi-K3 kernels and adapters while retaining stock AITER's public FlyDSL bootstrap and tensor shims. Wire the 12-head MLA decode layout without importing the excluded KDA decode boundary.
Use the vendored cooperative preactivated projection for M2/M4, retain the B1 path for M1, and fail closed to current-main materialization for larger batches.
Allow Kimi-K3 deployments to opt into an SGLang-owned M16384 BF16 GEMM profile before stock AITER initializes its tuning configuration.
Register FlyDSL tests with AMD CI and apply the formatting fixes required by the repository hooks.
Prevent AITER-specific Kimi-K3 flags and tuning profiles from activating on non-ROCm platforms.
|
@amd-bot ci-status |
CI Status for PR #35287Merge verdict: ❌ Do not merge yet. The PR's core deliverable — the vendored Kimi-K3 gfx950 (MI355X) FlyDSL kernels — is not verified by PR CI: all 14 numerical/correctness tests are gated Caution This PR's gfx950 kernel code is NOT exercised by any PR-CI test. On the only AMD Caution PR CI is incomplete. PR Test (Base) run 32214735204 fast-failed on Changed files (30): kernels under Executed CI failure attribution: AMD: 4 failures (0 related) · Others: 5 failures (0 related) · plus fast-fail cascades (collapsed) and 2 AMD shards pending. AMD Executed Failures
Other Executed Failures
Collapsed cascades (not independent failures): Details / what to do before merge
Generated by amd-bot using Claude Code CLI |
|
@amd-bot ci-status |
CI Status for PR #35287Merge verdict: 🔴 Do not merge. PR CI is incomplete (fast-fail cascades skipped downstream stages on Nvidia, AMD, and XPU) and there is one executed failure directly caused by this PR: on Nvidia, Caution Two coverage problems, both matter more than the unrelated red X's below:
Changed files (30): core = Executed CI failure attribution: AMD: 2 failures (0 related) · Others (Nvidia/NPU/XPU): 3 executed root failures (1 related). All other red jobs are fast-fail cascades collapsed into their roots below. Other Executed Failures
AMD Executed Failures
Details / what to do before merge
Generated by amd-bot using Claude Code CLI |
Route correctness tests to MI35x CI and cover the opt-in AITER feature gates while guarding uninitialized KDA state.
|
@amd-bot ci-status |
CI Status for PR #35287Merge verdict: ❌ Do not merge on "green." PR CI is incomplete and, more importantly, this PR's changed code was never exercised. All 5 new Kimi-K3 flydsl kernel tests register to the AMD MI35x (gfx950) suite Caution This PR's changed code is not verified by PR CI. The 5 new tests ( Changed files: 31 files (+5605/-41) — new Executed CI failure attribution: AMD: 0 real test failures (stage-b/c skipped, benchmark pending) · NVIDIA: 1 executed failure (0 related) · NPU: 1 executed failure (0 related). Many "failures" are fast-fail cascade / gate rollups, not independent failures. AMD CI — incomplete, not failed
Note: stage-a AMD did pass — NVIDIA / Other Executed Failures
The ~26 NVIDIA Details / what to do before merge
Generated by amd-bot using Claude Code CLI |
|
@amd-bot ci-status |
CI Status for PR #35287Merge verdict: Not safe to merge on "green" yet. NVIDIA is effectively green and the new Kimi-K3 gfx950 kernel unit tests ran and passed on gfx950, but PR CI is incomplete — ROCm 7.2 stage-c and most of the NPU pipeline were fast-fail skipped, so they are untested. None of the executed failures appear caused by this PR (they sit in code this PR does not touch, or are infra/flake), but this PR's runtime features are behind default-off env vars that no PR test sets, so the fused serving paths are not verified end-to-end. Caution Coverage gap — the PR's runtime feature paths are not exercised, and downstream CI was fast-fail skipped.
Changed files: 31 files, +5605/-41 — mostly new gfx950 FlyDSL kernels + unit tests under Executed CI failure attribution: AMD: 2 executed test failures (0 related) + 1 fast-fail gate · Others: 3 executed failures across NPU/XPU/Xeon (0 related). NVIDIA AMD Executed Failures
Other Executed Failures
Details / what to do before merge
Generated by amd-bot using Claude Code CLI |
|
@amd-bot ci-status |
CI Status for PR #35287Merge verdict: 🔴 Do not merge on green — this PR's changed code was not exercised by PR CI. All six new Kimi-K3 kernel tests register to the Caution This PR's changed code is not verified by PR CI. The AMD gate ( Changed files: 31 files, +5,605/-41 — new Executed CI failure attribution: AMD: 0 executed test failures (2 non-test infra/gate jobs, see caution) · Others: 6 executed failures (0 related to this PR) Other Executed Failures
(NPU Details / what to do before merge
Generated by amd-bot using Claude Code CLI |
Summary
Runtime configuration
Base Kimi-K3 AITER configuration:
Enable the PR features:
The latent-tail profile is independent and remains off by default because it reduces token capacity. Enable it only when explicitly evaluating that trade-off:
export SGLANG_K3_AITER_LATENT_TAIL_FP8=1The 12-head padding path has no feature flag. It is selected automatically for the covered Kimi-K3 shape when using AITER MLA decode, for example:
All integrations are shape/architecture guarded and fail closed to the existing implementation when the runtime contract is not covered.
Performance
+1.08%throughput,-1.11%TPOT over the prior M2 design.+3.08%throughput,-3.33%TPOT over the matched M4 baseline.+0.7%throughput at C8/C16/C32 and-2.34%C32 TTFT.Accuracy
0.9530.001Test plan
d9e5ef7: 35 passedgit diff --checkThe current container installs a newer FlyDSL than the old AITER pin expects for full-model MoE startup. The vendored focused kernels were tested directly against the exact pin; full-model smoke used the current compatible AITER checkout.
Made with Cursor
CI States
Latest PR Test (Base): ✅ Run #32579252160
Latest PR Test (Extra): ❌ Run #32579251698
Latest PR Test (AMD ROCm 7.2): ❌ Run #32579251895