[AMD] Add moe_ep_size/moe_tp_size to the allreduce-fusion gate test mock - #35251
Closed
kangwangamd wants to merge 1 commit into
Closed
[AMD] Add moe_ep_size/moe_tp_size to the allreduce-fusion gate test mock#35251kangwangamd wants to merge 1 commit into
kangwangamd wants to merge 1 commit into
Conversation
sgl-project#30700 made should_fuse_mlp_allreduce_with_next_layer read parallel.moe_ep_size and parallel.moe_tp_size, but the get_parallel mock in the AMD gate test only carries tp_size, so every case raises AttributeError. Set both to 1, which is the dense-TP configuration these tests exercise.
Contributor
Author
|
@wenscarl could you take a look? This is a test-only fix for the |
This was referenced Aug 18, 2026
Contributor
Author
|
Closing in favour of #35340, which makes the same change ( One data point in case it is useful: on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_aiter_allreduce_fusion_amd.py::TestAiterAllreduceFusionGatehas been red on bothpr-test-amdandpr-test-amd-rocm720since Aug-12 (log):#30700 added a hybrid EP+TP check to
should_fuse_mlp_allreduce_with_next_layer, so the gate now readsmoe_ep_sizeandmoe_tp_sizeoffget_parallel(). The mock in this test only providestp_size, so every case in the class raises before reaching its assertion.This adds both attributes to the mock, set to 1. That is the dense-TP configuration these tests are written for: the new guard only short-circuits when both are greater than 1, so 1/1 leaves
test_dense_tp_fusesasserting the fusion path as before, and the other cases still exercise the DP-attention and EP-backend branches they were added for.Test-only change; no source behaviour is affected.
Checklist
This repairs an existing test rather than adding one, and there is no documentation or performance impact.
CI States
Latest PR Test (Base): ❌ Run #32101495165
Latest PR Test (Extra): ❌ Run #32101494926