Skip to content

[Diffusion] Fail MiniMax-H3 quality="high" closed on substituted DiT weights #34978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickqian merged 3 commits into from
Oct 10, 2026
Merged

[Diffusion] Fail MiniMax-H3 quality="high" closed on substituted DiT weights #34978

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e000a0
[Diffusion] Fail MiniMax-H3 quality="high" closed on substituted DiT …
Raymondlol Aug 15, 2026
3e59eb5
Merge remote-tracking branch 'origin/main' into HEAD
mickqian Sep 4, 2026
e6ebd5c
Merge origin/main into minimax-h3-quality-weight-identity
mickqian Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/sglang/multimodal_gen/configs/pipeline_configs/minimax_h3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ def validate_quality_deployment(self, server_args) -> None:
"is_dit_layerwise_offload_selected": (
server_args.is_dit_layerwise_offload_selected
),
"lora_path": server_args.lora_path,
"model_variant": model_variant,
"num_gpus": server_args.num_gpus,
"performance_mode": server_args.performance_mode,
Expand All @@ -127,6 +128,7 @@ def validate_quality_deployment(self, server_args) -> None:
"ring_degree": server_args.ring_degree,
"sp_degree": server_args.sp_degree,
"tp_size": server_args.tp_size,
"transformer_weights_path": server_args.transformer_weights_path,
"ulysses_degree": server_args.ulysses_degree,
"use_fsdp_inference": server_args.use_fsdp_inference,
}
Expand All @@ -140,6 +142,7 @@ def validate_quality_deployment(self, server_args) -> None:
"enable_breakable_cuda_graph": False,
"enable_torch_compile": False,
"is_dit_layerwise_offload_selected": False,
"lora_path": None,
"model_variant": "fl2va",
"num_gpus": 4,
"performance_mode": "speed",
Expand All @@ -148,6 +151,7 @@ def validate_quality_deployment(self, server_args) -> None:
"ring_degree": 1,
"sp_degree": 4,
"tp_size": 1,
"transformer_weights_path": None,
"ulysses_degree": 4,
"use_fsdp_inference": False,
}
Expand Down
28 changes: 28 additions & 0 deletions python/sglang/multimodal_gen/test/unit/test_minimax_h3_admission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,14 @@ def _quality_server_args():
enable_breakable_cuda_graph=False,
enable_torch_compile=False,
is_dit_layerwise_offload_selected=False,
lora_path=None,
performance_mode="speed",
quantization=None,
regional_compile=False,
ring_degree=1,
sp_degree=4,
tp_size=1,
transformer_weights_path=None,
ulysses_degree=4,
use_fsdp_inference=False,
)
Expand Down Expand Up @@ -342,6 +344,32 @@ def test_quality_admission_fails_closed_outside_validated_request():
stage.forward(batch, server_args)


@pytest.mark.parametrize(
("field", "value"),
[
("lora_path", "larryvrh/MiniMax-H3-Turbo-Lora"),
("transformer_weights_path", "/weights/dit.safetensors"),
],
)
def test_quality_admission_rejects_substituted_dit_weights(field, value):
config = MiniMaxH3PipelineConfig()
server_args = _quality_server_args()

with (
patch.object(current_platform, "is_cuda", return_value=True),
patch.object(current_platform, "get_device_name", return_value="NVIDIA H200"),
patch.object(
current_platform,
"get_device_capability",
return_value=_HopperCapability(),
),
):
config.validate_quality_deployment(server_args)
setattr(server_args, field, value)
with pytest.raises(ValueError, match=field):
config.validate_quality_deployment(server_args)


def test_validate_server_args_requires_packed_varlen_backend():
config = SimpleNamespace(
vae_config=SimpleNamespace(resolved_parallel_decode_mode=lambda: None),
Expand Down
Loading