[AMD][CI] Name extra-suite jobs after the ROCm stack they run - #34630
Closed
michaelzhang-ai wants to merge 1 commit into
Closed
michaelzhang-ai wants to merge 1 commit into
michaelzhang-ai wants to merge 1 commit into
Conversation
#34204 made the extra suite suppress the ROCm 7.2 suffix and add -rocm700 for ROCm 7.0, inverting the convention its two callers use for their own jobs: pr-test-amd-rocm720.yml suffixes every job -rocm720 and pr-test-amd.yml leaves them bare. A ROCm 7.2 PR therefore shows stage-b-test-1-gpu-small-amd-rocm720 next to an unsuffixed extra-a-test-1-gpu-small-amd running the same container, and the six reusable-call job names flipped stacks mid-history for every name-keyed consumer (query_job_status.py --job prefixes, ci_failures_analysis.py clusters, the nightly CI job matrix). Suffix on the stack instead: -rocm720 for ROCm 7.2, bare for ROCm 7.0. pull_request runs get no inputs, so they resolve to the ROCm 7.2 default and are labelled -rocm720, matching the container they actually start. Co-authored-by: Michael <michaelzhang-ai@users.noreply.github.com>
michaelzhang-ai
marked this pull request as ready for review
August 12, 2026 20:57
michaelzhang-ai
requested review from
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ispobock and
merrymercy
as code owners
August 12, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#34204 swapped the AMD PR gate to ROCm 7.2 and, in
pr-test-amd-extra.yml, made the job display names suppress the suffix forrocm720and add-rocm700for ROCm 7.0. That inverts the convention both callers use for their own jobs:pr-test-amd-rocm720.ymlsuffixes every job-rocm720, andpr-test-amd.ymlleaves them bare.Two consequences today:
stage-b-test-1-gpu-small-amd-rocm720 (linux-mi300-1gpu-sglang)next to an unsuffixedextra-a-test-1-gpu-small-amd (linux-mi300-1gpu-sglang), even though both start the same ROCm 7.2 container.query_job_status.py --jobprefix reports (amd-ci-job-monitor.yml),ci_failures_analysis.pyfailure clusters, and the AMD nightly CI job matrix. The caller prefix (call-pr-test-amd-extravscall-pr-test-amd-extra-rocm720) keeps 7.0 and 7.2 rows distinct, so nothing is conflated — but each of the six rows is orphaned from its own past.Modifications
Suffix on the stack instead of on "is this the default":
-rocm720for ROCm 7.2, no suffix for ROCm 7.0.pull_requestruns of the extra workflow get noinputs, so they resolve to the ROCm 7.2 default and are labelled-rocm720, matching the container the job actually starts.maintodaypr-test-amd-rocm720.yml(7.2 gate)extra-a-test-1-gpu-small-amd-rocm720 (…)extra-a-test-1-gpu-small-amd (…)extra-a-test-1-gpu-small-amd-rocm720 (…)pr-test-amd.yml(7.0 shadow)extra-a-test-1-gpu-small-amd (…)extra-a-test-1-gpu-small-amd-rocm700 (…)extra-a-test-1-gpu-small-amd (…)pull_request(label-gated)extra-a-test-1-gpu-small-amd (…), ROCm 7.0 containerextra-a-test-1-gpu-small-amd (…), ROCm 7.2 containerextra-a-test-1-gpu-small-amd-rocm720 (…), ROCm 7.2 containerSame for
extra-a-test-1-gpu-large-amdandextra-a-test-2-gpu-large-amd. Both reusable-call rows go back to the names they carried before #34204, so their history reconnects.Only job display names change; job ids, suite names (
run_suite.py --suite extra-a-test-*-amd), therocm_versioninputs, and the containers are untouched. The one PR-visible change is the third row: the label-gated extra-a checks on a pull request gain the-rocm720suffix. They are gated behindrun-ci+run-ci-extraand so shouldn't be required checks, but worth confirming against branch protection before merge.actionlintis clean on the file.Accuracy Tests
N/A — CI job naming only.
Speed Tests and Profiling
N/A — CI job naming only.
Checklist
CI States
Latest PR Test (Base): ✅ Run #31640177469
Latest PR Test (Extra): ❌ Run #31640177272