Repository navigation
Conversation
BBuf
requested review from
AgainstEntropy,
HaiShaw,
mickqian,
ping1jing2 and
yichiche
as code owners
August 12, 2026 18:38
Collaborator
Author
|
Closing this candidate after the latest review. The Cosmos3 BCG path improved the measured B300 denoise latency, but the request-warmup lifecycle and model-specific state/test surface are not clean enough to justify the added maintenance risk. I will restore the B300 table to the retained main-branch result and mark this PR as closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable breakable CUDA graph for Cosmos3 Nano and preserve request warmup for request-only dimensions such as frame count.
The Cosmos-specific prompt padder keeps
max_text_seq_lenconsistent with the padded text mask. Warmup captures the requested text buckets before serving and forwards the current request context through the graph runner.B300 result
Cosmos3 Nano T2I, 1024px, 35 steps, native backend:
BCG is 3.09% faster in denoise and 3.06% faster end to end.
Validation
256 passed, 46 subtests passedPerformance was measured on commit
9deb6952afa483e38f96385a375b96f463da5303; this PR was rebased and retested on the latest main.CI States
Latest PR Test (Base): ✅ Run #31628635294
Latest PR Test (Extra): 🚫 Run #31630111122