Add zianglih as online NVFP4 and DSA Top-K code owner - #33624
Merged
Fridge003 merged 6 commits intoSep 7, 2026
Merged
Conversation
zianglih
marked this pull request as ready for review
August 5, 2026 00:39
zianglih
requested review from
Alisehen,
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
Fridge003,
HaiShaw,
Kangyan-Zhou,
OrangeRedeng,
b8zhong,
bingxche,
ch-wan,
ispobock,
merrymercy and
mmangkad
as code owners
August 5, 2026 00:39
zianglih
changed the title
ziang-and
force-pushed
the
agent/fix-nvfp4-online-ownership
branch
from
September 2, 2026 23:50
762cfb5 to
8b6a86d
Compare
zianglih
changed the title
Fridge003
reviewed
Sep 7, 2026
zianglih
changed the title
Fridge003
approved these changes
Sep 7, 2026
mqhc2020
pushed a commit
to mqhc2020/sglang
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@HumansAnd
The SGLang files covered by this PR were primarily implemented and are maintained by @zianglih through the Blackwell MXFP8 and NVFP4 RL roadmap and DSA Top-K work in #22851, #32490, #33006, and #36313.
Modifications
@zianglihthe sole file-specific code owner fornvfp4_online.py.@zianglihalongside the existing DSA owners fordsa_topk_backend.py.nvfp4_online.pywith links to the humans& and LMSYS implementation write-ups.Accuracy Tests
Not applicable; this PR changes only comments and ownership metadata.
Speed Tests and Profiling
Not applicable; this PR does not change runtime behavior.
Checklist
CI States
Latest PR Test (Base): ❌ Run #34168846136
Latest PR Test (Extra): ❌ Run #34168845725
Latest PR Test (AMD ROCm 7.2): ❌ Run #34168846072