Skip to content

[Fix] Resolve VLM test image placeholders from the model's own chat template - #33509

Merged
hnyls2002 merged 5 commits into
mainfrom
lsyin/vlm-test-image-placeholder
Aug 4, 2026
Merged

hnyls2002 merged 5 commits into
mainfrom
lsyin/vlm-test-image-placeholder

Conversation

@hnyls2002

@hnyls2002 hnyls2002 commented Aug 4, 2026 •

Copy link
Copy Markdown
Collaborator

VLM tests built their image placeholder from sglang.lang.chat_template -- a frontend-only registry with no contract with the server's multimodal processors -- so models with no entry there fell back to <image> and the image was silently dropped. Tests now get the placeholder from the server or the model's own HF chat template.


CI States

Latest PR Test (Base): ❌ Run #30891678976
Latest PR Test (Extra): ❌ Run #30891679079

@hnyls2002
hnyls2002 requested a review from ping1jing2 as a code owner August 4, 2026 08:06
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions github-actions Bot added the npu label Aug 4, 2026
@hnyls2002

Copy link
Copy Markdown
Collaborator Author

/rerun-test test_dp_attention.py test_skip_tokenizer_init.py test_piecewise_cuda_graph_support_1_gpu.py

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Results for /rerun-test test_dp_attention.py test_skip_tokenizer_init.py test_piecewise_cuda_graph_support_1_gpu.py:

🚀 2-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/dp_attn/test_dp_attention.py

🚀 1-gpu-5090 (1 test): ✅ View workflow run

cd test/ && python3 registered/tokenizer/test_skip_tokenizer_init.py

🚀 1-gpu-h100 (1 test): ✅ View workflow run

cd test/ && python3 registered/cuda_graph/piecewise/test_piecewise_cuda_graph_support_1_gpu.py

@hnyls2002
hnyls2002 merged commit b6d548a into main Aug 4, 2026
116 of 132 checks passed
@hnyls2002
hnyls2002 deleted the lsyin/vlm-test-image-placeholder branch August 4, 2026 09:01
saturn-acc pushed a commit to saturn-acc/sglang that referenced this pull request Aug 16, 2026
Atituiset pushed a commit to Atituiset/sglang that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant