Conversation
ormandj
requested review from
JustinTong0323,
sogalin,
wisclmy0611 and
zijiexia
as code owners
July 31, 2026 23:55
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Author
|
@mmangkad @JustinTong0323 @b8zhong @AliceChenyy, could you review this alongside #33140? The functional distinction is checkpoint selection: this version uses the existing checkpoint_bundles_dspark_draft() config signal instead of a model-path substring. It also updates the SGLANG_DSV4_REASONING_EFFORT documentation and covers request filtering, invalid values, and legacy behavior. |
Collaborator
Leoyzen
added a commit
to Leoyzen/sglang
that referenced
this pull request
Aug 8, 2026
…project#32035 sgl-project#33656 sgl-project#32183 sgl-project#33145) Applied PRs (latest from GitHub): sgl-project#33288 Indexer logits OOM fix sgl-project#30393 HiCache packed/sidecar draft caches sgl-project#31170 DPA prefix_affinity load balancing sgl-project#33795 DSpark compact ragged-verify CUDA graph JIT race sgl-project#32467 C128 plan-kernel warp barrier sgl-project#33865 DSpark x prefill CP unblock sgl-project#30371 SWA state pool sizing (storage page) sgl-project#33358 FlashMLA norm-rope K-tokens-per-block ILP sgl-project#33872 num_draft_tokens clamp + extend_len==0 skip (supersede sgl-project#32183) sgl-project#34002 Sidecar backup vacuously-successful fix (replaces sgl-project#33656, with tests) sgl-project#33862 Reclaim redundant host mirrors after storage backup sgl-project#31315 Avoid repeated Mooncake gets after stale hits sgl-project#32327 Q8KV8 sparse MLA prefill backend (flashmla_sparse_q8) sgl-project#31668 Fix sidecar pool life-time (use-after-free on prefetch abort) sgl-project#31195 TP0 verify-token-budget broadcast (adapted to get_schedule() API) Dropped (per user request or superseded): sgl-project#32771 IndexCache C4 top-k reuse — has bug sgl-project#32035 DSpark C128 online compressor — has bug sgl-project#33656 Superseded by sgl-project#34002 (same fix + unit tests) sgl-project#32183 Superseded by sgl-project#33872 (included in supersede PR) sgl-project#33145 Base f01f706 already has superior reasoning-effort profile system Conflicts resolved: sgl-project#31195: adapted to base get_schedule().disable_overlap_schedule API sgl-project#32327: path remapped jit_kernel/ -> kernels/jit/ and kernels/ops/attention/ sgl-project#31668: applied cleanly on top of sgl-project#30393+sgl-project#34002+sgl-project#33862 modifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepSeek-V4-Flash-0731/encoding/encoding_dsv4.pydefines three reasoning-effort tiers. SGLang currently preserves the earlier DeepSeek-V4 contract, wherehighadds no prefix andmaxadds the "Absolute maximum" prefix. Applying the newer mapping to every DeepSeek-V4 checkpoint would change existing behavior.lowhighmaxModifications
checkpoint_bundles_dspark_draft()helper. The HF config carries no encoding-version field, so this uses the bundleddspark_*config keys as the proxy; any DeepSeek-V4 checkpoint carrying those keys selects the newer mapping.Accuracy Tests
uv run --no-project python -m pytest -q test/registered/unit/entrypoints/openai/test_serving_chat.py: 86 passed and 30 subtests passed.DeepSeek-V4-Flash-0731, a one-message"Hello"request withmax_tokens=8produced prompt-token counts of 5, 84, and 97 forlow,high, andmax, respectively.Speed Tests and Profiling
Not run. This changes which prompt prefix is emitted.
Checklist
SGLANG_DSV4_REASONING_EFFORTreference now describes the checkpoint-specific accepted values.AI was used to assist with implementation.
CI States
Latest PR Test (Base): ❌ Run #30674188412
Latest PR Test (Extra): ❌ Run #30674188407