Repository navigation
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
27b4a9a to
16b2750
Compare
💡 Codex Reviewhttps://github.com/sgl-project/sglang/blob/27b4a9a918b4b2b5fe9db6e857b14a788af94586/python/sglang/srt/managers/scheduler.py#L1832-L1837 When https://github.com/sgl-project/sglang/blob/27b4a9a918b4b2b5fe9db6e857b14a788af94586/python/sglang/srt/managers/rust_server.py#L81-L85 When https://github.com/sgl-project/sglang/blob/27b4a9a918b4b2b5fe9db6e857b14a788af94586/rust/sglang-server/src/api_server/openai.rs#L90-L93 When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ng-text, handler tests
Motivation
Implemented the full OpenAI APIs for rust sglang server.
Based on #29799
Modifications
Implemented APIs:
v1/modelsv1/completionsv1/chat/completionsv1/responsesSome design decisions
nfanout: Fan-out in HTTP layer — submitsnseparateGenerateRequests, each withn=1. Matches external API behavior, avoids nativen > 1rejection--api-keyBearer token gating on all OpenAI endpoints (default: open for no key configured)function_call/functions: Explicitly rejected with migration message (Python silently ignores)text_offset: SGLang emits[-1]sentinels; post-processed incompletion_response_valuesince Dynamo types it asu32system_fingerprint: Removed from responses (Python doesn't include it)reasoning_content: null: Serialized into every SSE delta chunk (Python compat)Accuracy Tests
TestOpenAIServer,TestOpenAIFunctionCalling,TestOpenAIResponsesclasses reused verbatim behindis_rust_server_built()guards via class attribute aliasingSpeed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #30651200216
Latest PR Test (Extra): ❌ Run #30651196411