Skip to content

fix mm-chunk-embedding test suite - #32895

Merged
mingfeima merged 10 commits into
sgl-project:mainfrom
ZailiWang:mm-chunk-emb-fix
Aug 5, 2026
Merged

mingfeima merged 10 commits into
sgl-project:mainfrom
ZailiWang:mm-chunk-emb-fix

Conversation

@ZailiWang

@ZailiWang ZailiWang commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Motivation

Fix CPU ci failure introduced in #31826 .

Modifications


CI States

Latest PR Test (Base): 🚫 Run #30894746752
Latest PR Test (Extra): ❌ Run #30894746421

@ZailiWang

Copy link
Copy Markdown
Contributor Author

/tag-run-ci-label

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@ZailiWang

Copy link
Copy Markdown
Contributor Author

@mingfeima mingfeima added intel cpu cpu backend performance optimization labels Aug 4, 2026
@mingfeima

Copy link
Copy Markdown
Collaborator

only move to base-a won't fix this issue. The test case test_mm_chunked_embedding_unit.py still fails.

=========================== short test summary info ============================
FAILED registered/chunked_prefill/test_mm_chunked_embedding_unit.py::test_by_item_list_matches_tensor - AssertionError: attention tensor model parallel group is not initialized
FAILED registered/chunked_prefill/test_mm_chunked_embedding_unit.py::test_full_list_matches_tensor - AssertionError: attention tensor model parallel group is not initialized
FAILED registered/chunked_prefill/test_mm_chunked_embedding_unit.py::test_full_matches_by_item - AssertionError: attention tensor model parallel group is not initialized
=================== 3 failed, 2 passed, 2 warnings in 0.72s ====================
.
.
End (4/46):
filename='/home/runner/work/sglang/sglang/test/registered/chunked_prefill/test_mm_chunked_embedding_unit.py', elapsed=12, estimated_time=10.0
.
.


✗ FAILED: /home/runner/work/sglang/sglang/test/registered/chunked_prefill/test_mm_chunked_embedding_unit.py returned exit code 1

@mingfeima mingfeima left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a runtime fixture in test case to bypass single process CPU for parallel GPU run.

Comment thread test/registered/chunked_prefill/test_mm_chunked_embedding_unit.py
Comment thread test/registered/chunked_prefill/test_mm_chunked_embedding_unit.py
@mingfeima
mingfeima merged commit 29831d5 into sgl-project:main Aug 5, 2026
131 of 147 checks passed
@ZailiWang
ZailiWang deleted the mm-chunk-emb-fix branch August 5, 2026 02:00
saturn-acc pushed a commit to saturn-acc/sglang that referenced this pull request Aug 16, 2026
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
Jianhong-Zhang pushed a commit to Jianhong-Zhang/sglang that referenced this pull request Aug 18, 2026
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
Atituiset pushed a commit to Atituiset/sglang that referenced this pull request Sep 10, 2026
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpu cpu backend performance optimization intel run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants