fix mm-chunk-embedding test suite - #32895
Merged
Merged
Conversation
Contributor
Author
|
/tag-run-ci-label |
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Author
Collaborator
|
only move to base-a won't fix this issue. The test case test_mm_chunked_embedding_unit.py still fails. |
mingfeima
requested changes
Aug 4, 2026
mingfeima
left a comment
Collaborator
There was a problem hiding this comment.
add a runtime fixture in test case to bypass single process CPU for parallel GPU run.
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
mingfeima
approved these changes
Aug 5, 2026
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 16, 2026
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
Jianhong-Zhang
pushed a commit
to Jianhong-Zhang/sglang
that referenced
this pull request
Aug 18, 2026
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
Co-authored-by: Ma Mingfei <mingfei.ma@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix CPU ci failure introduced in #31826 .
Modifications
CI States
Latest PR Test (Base): 🚫 Run #30894746752
Latest PR Test (Extra): ❌ Run #30894746421