Repository navigation
[Spec] Emit step trace span for multi-layer draft-extend graph replays - #32850
Merged
Merged
Conversation
hnyls2002
requested review from
Qiaolin-Yu,
Ying1123 and
merrymercy
as code owners
July 30, 2026 02:07
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
/tag-and-rerun-ci |
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 16, 2026
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every forward phase gets a
step[<MODE> bs=N]trace span from ModelRunner.forward, but the multi-layer EAGLE decode draft-extend replays its cuda graphs directly through the graph runner (cgr.prepare+cgr.replay(step)), bypassing that entry. In profiler traces the draft phase's kernels therefore show up underscheduler.run_batchwith no step marker, while TARGET_VERIFY and EXTEND have theirs.Wrap the graph-replay block in
profile_range(build_step_span_name(forward_batch))so traces now carrystep[DRAFT_EXTEND_V2 bs=N]alongside the existing spans. Pure observability: the wrapper resolves to a shared no-op context when no profiler is active, and the prefill-side chain already goes through ModelRunner.forward so it needs nothing.Verified on a tp=8 EAGLE run: captured trace shows
step[DRAFT_EXTEND_V2 bs=1]spans matching the draft replay windows; generated output unchanged.CI States
Latest PR Test (Base): 🚫 Run #30507587448
Latest PR Test (Extra): ❌ Run #30507587349