Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Author
|
@AliceChenyy @b8zhong @mmangkad — review requested for the SM120 DeepGEMM capability gate. This draft is pending #29927. |
ormandj
force-pushed
the
perf/sm120-fp8-wo-a-default
branch
from
September 6, 2026 20:42
1dbf09f to
042331e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On DeepSeek-V4 SM120 the model override currently forces
SGLANG_OPT_FP8_WO_A_GEMMoff. #29927 is now merged; that override bypasses a supported path on capable builds. The global default is true, and the later DeepGEMM capability check already disables builds that cannot run the GEMM.Modifications
DEEPGEMM_SCALE_UE8M0.Default behavior changes only for DeepSeek-V4 on capable SM120 builds.
Accuracy Tests
Rebased on main
2c05ed4e77. Author test logs and source bindings record the tested snapshots. The subsequent main refresh changes only unrelated ROCm/NPU files; each repaired patch is byte-identical across that refresh. Author CPU validation passed 91 tests and 29 subtests with one skip. The helper now lives inarg_groups/model_hook.py.The following accuracy and speed results are retained author reports from the original source identified below, not new measurements of this rebase.
DeepSeek-V4-Flash, TP=2, 2x RTX PRO 6000, temperature 0, no MTP, and no DSpark. The source was current main
ffd4705baa39+ #2992741ee852a6eb6+ this PR1dbf09f6e015, with no other SGLang PRs or runtime source overlays.The paired 1,319-question GSM8K run scored 1,250 correct with the flag off and 1,246 correct with the default enabled. There were 14 candidate-only and 18 control-only successes; McNemar p = 0.5966 and the paired bootstrap 95% interval was -1.14 to +0.53 percentage points. All 2,638 responses stopped cleanly with zero invalid or failed responses.
Speed Tests and Profiling
The control set
SGLANG_OPT_FP8_WO_A_GEMM=0; the candidate left the variable unset. The source, image, dependencies, arguments, and hardware were otherwise identical. Sustained decode used zero-token contexts, 30-second cells, and a maximum of 8,192 output tokens. Each value is the median of five runs.The five-run coding median changed from 97.68 to 99.64 tok/s (+2.00%). KV-cache token capacity changed from 1,723,648 to 1,823,488 (+5.79%).
The focused unit test and pre-commit checks pass. In the candidate container, the runtime source HEAD/tree matched
62d35aaa5e82/d0961aec18dd, the environment variable was absent, the DeepGEMM capability reported true, and the effective default remained true.Checklist
Developed with AI assistance.
CI States
Latest PR Test (Base): ❌ Run #34058833439
Latest PR Test (Extra): ❌ Run #34058833395
Latest PR Test (AMD ROCm 7.2): ❌ Run #34058833636