Repository navigation
Follow up on #30157 post-merge review - #32672
Merged
Merged
Conversation
cctry
requested review from
Fridge003,
Ying1123,
hnyls2002 and
merrymercy
as code owners
July 28, 2026 18:38
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
cctry
requested review from
alphabetc1,
hanming-lu,
hzh0425,
ispobock,
xiezhq-hermann and
yizhang2077
as code owners
July 28, 2026 18:38
Collaborator
Author
|
/tag-and-rerun-ci |
saturn-acc
pushed a commit
to saturn-acc/sglang
that referenced
this pull request
Aug 16, 2026
Atituiset
pushed a commit
to Atituiset/sglang
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Addresses merrymercy’s post-merge comments on #30157: the reserve helper name implied Mamba-only semantics, and the KV-pool paths used getattr fallbacks.
Fix: Rename the helper to pre_capture_activation_reserve_mb, initialize k/v buffers before descriptor construction, and use direct attribute access. No reserve or sizing behavior changes.
CI States
Latest PR Test (Base): ✅ Run #30388325458
Latest PR Test (Extra): ❌ Run #30388323412