Skip to content

Fix MoE reduce-scatterv eligibility check - #32663

Merged
Qiaolin-Yu merged 1 commit into
sgl-project:mainfrom
samuellees:fix/reduce-scatterv-group-size-check
Jul 29, 2026
Merged

Qiaolin-Yu merged 1 commit into
sgl-project:mainfrom
samuellees:fix/reduce-scatterv-group-size-check

Conversation

@samuellees

@samuellees samuellees commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Enable DP reduce-scatterv only when the TP group size matches the attention-DP split count.
  • Fall back to all-reduce plus DP scatter when the group sizes do not match.
  • Add unit tests covering both valid and fallback paths

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ✅ Run #30369958254
Latest PR Test (Extra): ✅ Run #30450094634

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@ispobock ispobock added run-ci CI: run the baseline test suite on this PR run-ci-extra CI: also run the extra suite (requires run-ci) bypass-fastfail labels Jul 29, 2026
@ispobock

Copy link
Copy Markdown
Collaborator

/tag-and-rerun-ci

@Qiaolin-Yu Qiaolin-Yu self-assigned this Jul 29, 2026
@Qiaolin-Yu
Qiaolin-Yu merged commit 8fc54d4 into sgl-project:main Jul 29, 2026
269 of 316 checks passed
saturn-acc pushed a commit to saturn-acc/sglang that referenced this pull request Aug 16, 2026
Atituiset pushed a commit to Atituiset/sglang that referenced this pull request Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass-fastfail run-ci CI: run the baseline test suite on this PR run-ci-extra CI: also run the extra suite (requires run-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants