Fix constrained grammar stop-token handling - #32509
Open
emilyhanyf wants to merge 1 commit into
Open
emilyhanyf wants to merge 1 commit into
emilyhanyf wants to merge 1 commit into
Conversation
Union tokenizer stop tokens with model-configured EOS tokens so grammar-constrained generation can terminate consistently with runtime stop detection. Co-authored-by: Cursor <cursoragent@cursor.com>
emilyhanyf
requested review from
DarkSharpness,
JustinTong0323 and
hnyls2002
as code owners
July 27, 2026 09:10
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Union tokenizer stop tokens with model-configured EOS tokens so grammar-constrained generation can terminate consistently with runtime stop detection.
Motivation
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #30252840626
Latest PR Test (Extra): ❌ Run #30252838665